diff --git a/deps/v8/ChangeLog b/deps/v8/ChangeLog index 88c34f9f11..d07c4586d5 100644 --- a/deps/v8/ChangeLog +++ b/deps/v8/ChangeLog @@ -1,3 +1,11 @@ +2009-10-07: Version 1.3.15 + + Expand the maximum size of the code space to 512MB for 64-bit mode. + + Fixed a crash bug happening when starting profiling (issue + http://crbug.com/23768). + + 2009-10-07: Version 1.3.14 Added GetRealNamedProperty to the API to lookup real properties diff --git a/deps/v8/src/debug.cc b/deps/v8/src/debug.cc index ec658d68f0..4f89f92e97 100644 --- a/deps/v8/src/debug.cc +++ b/deps/v8/src/debug.cc @@ -1677,22 +1677,6 @@ void Debug::ClearMirrorCache() { } -// If an object given is an external string, check that the underlying -// resource is accessible. For other kinds of objects, always return true. -static bool IsExternalStringValid(Object* str) { - if (!str->IsString() || !StringShape(String::cast(str)).IsExternal()) { - return true; - } - if (String::cast(str)->IsAsciiRepresentation()) { - return ExternalAsciiString::cast(str)->resource() != NULL; - } else if (String::cast(str)->IsTwoByteRepresentation()) { - return ExternalTwoByteString::cast(str)->resource() != NULL; - } else { - return true; - } -} - - void Debug::CreateScriptCache() { HandleScope scope; @@ -1711,7 +1695,7 @@ void Debug::CreateScriptCache() { while (iterator.has_next()) { HeapObject* obj = iterator.next(); ASSERT(obj != NULL); - if (obj->IsScript() && IsExternalStringValid(Script::cast(obj)->source())) { + if (obj->IsScript() && Script::cast(obj)->HasValidSource()) { script_cache_->Add(Handle