mirror of https://github.com/lukechilds/node.git
Browse Source
Previously, test-cluster-disconnect-leak had two issues: * Magic numbers: How many times to spawn a worker was determined through empirical experimentation. This means that as new platforms and new CPU/RAM configurations are tested, the magic numbers require more and more refinement. This brings us to... * Non-determinism: The test *seems* to fail all the time when the bug it tests for is present, but it's really a judgment based on sampling. "Oh, with 8 workers per CPU, it fails about 80% of the time. Let's try 16..." This revised version of the test takes a different approach. The fix for the bug that the test was written for means that the `disconnect` event will fire reliably for a single worker. So we check for that and the test still fails when the fix is not in the code base and succeeds when it is. Advantages of this approach include: * The test runs much faster. * The test now works on Windows. The previous version skipped Windows. * The test should be reliable on any new platform regardless of CPU and RAM. Ref: https://github.com/nodejs/node/pull/4674 PR-URL: https://github.com/nodejs/node/pull/4736 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>process-exit-stdio-flushing
Rich Trott
9 years ago
committed by
James M Snell
1 changed files with 14 additions and 32 deletions
@ -1,47 +1,29 @@ |
|||||
'use strict'; |
'use strict'; |
||||
// Flags: --expose-internals
|
|
||||
|
// Test fails in Node v5.4.0 and passes in v5.4.1 and newer.
|
||||
|
|
||||
const common = require('../common'); |
const common = require('../common'); |
||||
const assert = require('assert'); |
|
||||
const net = require('net'); |
const net = require('net'); |
||||
const cluster = require('cluster'); |
const cluster = require('cluster'); |
||||
const handles = require('internal/cluster').handles; |
|
||||
const os = require('os'); |
|
||||
|
|
||||
if (common.isWindows) { |
const noop = () => {}; |
||||
console.log('1..0 # Skipped: This test does not apply to Windows.'); |
|
||||
return; |
|
||||
} |
|
||||
|
|
||||
cluster.schedulingPolicy = cluster.SCHED_NONE; |
cluster.schedulingPolicy = cluster.SCHED_NONE; |
||||
|
|
||||
if (cluster.isMaster) { |
if (cluster.isMaster) { |
||||
const cpus = os.cpus().length; |
const worker = cluster.fork(); |
||||
const tries = cpus > 8 ? 128 : cpus * 16; |
|
||||
|
// This is the important part of the test: Confirm that `disconnect` fires.
|
||||
const worker1 = cluster.fork(); |
worker.on('disconnect', common.mustCall(noop)); |
||||
worker1.on('message', common.mustCall(() => { |
|
||||
worker1.disconnect(); |
// These are just some extra stuff we're checking for good measure...
|
||||
for (let i = 0; i < tries; ++ i) { |
worker.on('exit', common.mustCall(noop)); |
||||
const w = cluster.fork(); |
cluster.on('exit', common.mustCall(noop)); |
||||
w.on('online', common.mustCall(w.disconnect)); |
|
||||
} |
|
||||
})); |
|
||||
|
|
||||
cluster.on('exit', common.mustCall((worker, code) => { |
|
||||
assert.strictEqual(code, 0, 'worker exited with error'); |
|
||||
}, tries + 1)); |
|
||||
|
|
||||
process.on('exit', () => { |
|
||||
assert.deepEqual(Object.keys(cluster.workers), []); |
|
||||
assert.strictEqual(Object.keys(handles).length, 0); |
|
||||
}); |
|
||||
|
|
||||
|
cluster.disconnect(); |
||||
return; |
return; |
||||
} |
} |
||||
|
|
||||
var server = net.createServer(); |
const server = net.createServer(); |
||||
|
|
||||
server.listen(common.PORT, function() { |
server.listen(common.PORT); |
||||
process.send('listening'); |
|
||||
}); |
|
||||
|
Loading…
Reference in new issue