Browse Source

doc: correct vcbuild options for windows testing

Corrected parameter for running tests on Windows. Without the corrected
parameters, Windows users encounter an error about failing to sign the
build, "Failed to sign exe", which can be discouraging to new Windows
community members.

PR-URL: https://github.com/nodejs/node/pull/10686
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
v4.x
Jonathan Boarman 8 years ago
committed by Myles Borins
parent
commit
d8961bdb3b
No known key found for this signature in database GPG Key ID: 933B01F40B5CA946
  1. 10
      BUILDING.md
  2. 6
      CONTRIBUTING.md

10
BUILDING.md

@ -123,7 +123,7 @@ Prerequisites:
To run the tests:
```text
> .\vcbuild test
> .\vcbuild nosign test
```
To test if Node.js was built correctly:
@ -172,7 +172,7 @@ $ ./configure --with-intl=small-icu --download=all
##### Windows:
```text
> .\vcbuild small-icu download-all
> .\vcbuild nosign small-icu download-all
```
The `small-icu` mode builds with English-only data. You can add full
@ -195,7 +195,7 @@ $ ./configure --with-intl=full-icu --download=all
##### Windows:
```text
> .\vcbuild full-icu download-all
> .\vcbuild nosign full-icu download-all
```
#### Building without Intl support
@ -212,7 +212,7 @@ $ ./configure --with-intl=none
##### Windows:
```text
> .\vcbuild intl-none
> .\vcbuild nosign intl-none
```
#### Use existing installed ICU (Unix / OS X only):
@ -251,7 +251,7 @@ First unpack latest ICU to `deps/icu`
as `deps/icu` (You'll have: `deps/icu/source/...`)
```text
> .\vcbuild full-icu
> .\vcbuild nosign full-icu
```
## Building Node.js with FIPS-compliant OpenSSL

6
CONTRIBUTING.md

@ -164,7 +164,7 @@ $ ./configure && make -j8 test
Windows:
```text
> vcbuild test
.\vcbuild nosign test
```
(See the [BUILDING.md](./BUILDING.md) for more details.)
@ -172,11 +172,11 @@ Windows:
Make sure the linter is happy and that all tests pass. Please, do not submit
patches that fail either check.
Running `make test`/`vcbuild test` will run the linter as well unless one or
Running `make test`/`.\vcbuild nosign test` will run the linter as well unless one or
more tests fail.
If you want to run the linter without running tests, use
`make lint`/`vcbuild jslint`.
`make lint`/`.\vcbuild nosign jslint`.
If you are updating tests and just want to run a single test to check it, you
can use this syntax to run it exactly as the test harness would:

Loading…
Cancel
Save