From d98ae6a5416b9ee34eb40bbb1b8ae785896f2bc1 Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Sat, 1 Oct 2016 00:20:16 +0200 Subject: [PATCH] build: don't build icu with -fno-rtti MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ICU should be compiled with -frtti (and it sets that flag in its gyp file) but it was also inheriting the -fno-rtti flag from common.gypi, breaking the build on some systems. Fixes: https://github.com/nodejs/node/issues/8867 PR-URL: https://github.com/nodejs/node/pull/8886 Reviewed-By: Johan Bergström Reviewed-By: Franziska Hinkelmann --- tools/icu/icu-generic.gyp | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/icu/icu-generic.gyp b/tools/icu/icu-generic.gyp index ecbf6d18c2..3a284461d8 100644 --- a/tools/icu/icu-generic.gyp +++ b/tools/icu/icu-generic.gyp @@ -67,6 +67,7 @@ [ 'os_posix == 1 and OS != "mac" and OS != "ios"', { 'cflags': [ '-Wno-deprecated-declarations' ], 'cflags_cc': [ '-frtti' ], + 'cflags_cc!': [ '-fno-rtti' ], }], [ 'OS == "mac" or OS == "ios"', { 'xcode_settings': {'GCC_ENABLE_CPP_RTTI': 'YES' },