From d9c33646e677efdc8c7c9d2ba70b230b15e8d142 Mon Sep 17 00:00:00 2001
From: Niels Nielsen <niels@protectwise.com>
Date: Tue, 18 Oct 2016 22:30:03 +0200
Subject: [PATCH] test: add regression test for `unpipe()`

Since 2e568d9 there is a bug where unpiping a stream
from a readable stream that has `_readableState.pipesCount > 1`
will cause it to remove the first stream in the
`_.readableState.pipes` array no matter where in the list the
`dest` stream was.

Ref: https://github.com/nodejs/node/pull/9553
PR-URL: https://github.com/nodejs/node/pull/9171
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
---
 .../test-stream-pipe-unpipe-streams.js        | 32 +++++++++++++++++++
 1 file changed, 32 insertions(+)
 create mode 100644 test/parallel/test-stream-pipe-unpipe-streams.js

diff --git a/test/parallel/test-stream-pipe-unpipe-streams.js b/test/parallel/test-stream-pipe-unpipe-streams.js
new file mode 100644
index 0000000000..8858ac5733
--- /dev/null
+++ b/test/parallel/test-stream-pipe-unpipe-streams.js
@@ -0,0 +1,32 @@
+'use strict';
+const common = require('../common');
+const assert = require('assert');
+
+const Stream = require('stream');
+const Readable = Stream.Readable;
+const Writable = Stream.Writable;
+
+const source = Readable({read: () => {}});
+const dest1 = Writable({write: () => {}});
+const dest2 = Writable({write: () => {}});
+
+source.pipe(dest1);
+source.pipe(dest2);
+
+dest1.on('unpipe', common.mustCall(() => {}));
+dest2.on('unpipe', common.mustCall(() => {}));
+
+assert.strictEqual(source._readableState.pipes[0], dest1);
+assert.strictEqual(source._readableState.pipes[1], dest2);
+assert.strictEqual(source._readableState.pipes.length, 2);
+
+// Should be able to unpipe them in the reverse order that they were piped.
+
+source.unpipe(dest2);
+
+assert.strictEqual(source._readableState.pipes, dest1);
+assert.notStrictEqual(source._readableState.pipes, dest2);
+
+source.unpipe(dest1);
+
+assert.strictEqual(source._readableState.pipes, null);