mirror of https://github.com/lukechilds/node.git
Browse Source
IPv6 addresses in Host header (URI), must be enclosed within square brackets, in order to properly separate the host address from any port reference. PR-URL: https://github.com/nodejs/node/pull/5314 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>process-exit-stdio-flushing
Mihai Potra
9 years ago
committed by
James M Snell
2 changed files with 51 additions and 0 deletions
@ -0,0 +1,40 @@ |
|||||
|
'use strict'; |
||||
|
/* |
||||
|
* When using the object form of http.request and using an IPv6 address |
||||
|
* as a hostname, and using a non-standard port, the Host header |
||||
|
* is improperly formatted. |
||||
|
* Issue: https://github.com/nodejs/node/issues/5308
|
||||
|
* As per https://tools.ietf.org/html/rfc7230#section-5.4 and
|
||||
|
* https://tools.ietf.org/html/rfc3986#section-3.2.2
|
||||
|
* the IPv6 address should be enclosed in square brackets |
||||
|
*/ |
||||
|
|
||||
|
const common = require('../common'); |
||||
|
const assert = require('assert'); |
||||
|
const http = require('http'); |
||||
|
|
||||
|
const hostname = '::1'; |
||||
|
const port = common.PORT; |
||||
|
|
||||
|
function httpreq() { |
||||
|
var req = http.request({ |
||||
|
host: hostname, |
||||
|
port: port, |
||||
|
path: '/', |
||||
|
method: 'GET' |
||||
|
}); |
||||
|
req.end(); |
||||
|
} |
||||
|
|
||||
|
if (!common.hasIPv6) { |
||||
|
console.error('Skipping test, no IPv6 support'); |
||||
|
return; |
||||
|
} |
||||
|
|
||||
|
const server = http.createServer(common.mustCall(function(req, res) { |
||||
|
assert.ok(req.headers.host, `[${hostname}]`); |
||||
|
res.end(); |
||||
|
server.close(true); |
||||
|
})); |
||||
|
|
||||
|
server.listen(port, hostname, () => httpreq()); |
Loading…
Reference in new issue