mirror of https://github.com/lukechilds/node.git
Browse Source
It doesn't seem to make much sense to have the mentioned typedef declaration equipped with NODE_EXTERN. In fact, when compiling with GCC, an attribute specifier like __attribute__((visibility("default"))) in such a typedef declaration will cause the following warning message: warning: ‘visibility’ attribute ignored [-Wattributes] The issue goes unnoticed because NODE_EXTERN is defined as nothing for GCC builds, but for correctness it's better to not specify it here at all. PR-URL: https://github.com/nodejs/node/pull/14466 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com>v6.x
Jiajie Hu
8 years ago
committed by
Myles Borins
1 changed files with 1 additions and 1 deletions
Loading…
Reference in new issue