Browse Source

build: codesign tarball binary on macOS

Previously, we were signing the binary that was released in the .pkg,
but not the binary released in the tarball.

PR-URL: https://github.com/nodejs/node/pull/14179
Fixes: https://github.com/nodejs/node/issues/11936
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
v4.x-staging
Evan Lucas 8 years ago
committed by Myles Borins
parent
commit
dc05da730f
No known key found for this signature in database GPG Key ID: 933B01F40B5CA946
  1. 3
      Makefile

3
Makefile

@ -617,6 +617,9 @@ $(BINARYTAR): release-only
cp README.md $(BINARYNAME) cp README.md $(BINARYNAME)
cp LICENSE $(BINARYNAME) cp LICENSE $(BINARYNAME)
cp CHANGELOG.md $(BINARYNAME) cp CHANGELOG.md $(BINARYNAME)
ifeq ($(OSTYPE),darwin)
SIGN="$(CODESIGN_CERT)" PKGDIR="$(BINARYNAME)" bash tools/osx-codesign.sh
endif
tar -cf $(BINARYNAME).tar $(BINARYNAME) tar -cf $(BINARYNAME).tar $(BINARYNAME)
rm -rf $(BINARYNAME) rm -rf $(BINARYNAME)
gzip -c -f -9 $(BINARYNAME).tar > $(BINARYNAME).tar.gz gzip -c -f -9 $(BINARYNAME).tar > $(BINARYNAME).tar.gz

Loading…
Cancel
Save