Browse Source

test: use normalize() for unicode paths

OS X 10.11 changed the unicode normalization form of certain code points
returned by system calls like getcwd() from NFC to NFD which made
results in this test failing.

The consensus of https://github.com/nodejs/node/issues/2165 is to delegate
the task of unicode normalization to the user, and work will continue to
document how to handle unicode in a form-sensitive file system.

PR-URL: https://github.com/nodejs/node/pull/3007
Fixes: https://github.com/nodejs/node/issues/2165
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
v4.x
Roman Reiss 9 years ago
committed by James M Snell
parent
commit
ddf258376d
  1. 16
      test/parallel/test-process-chdir.js

16
test/parallel/test-process-chdir.js

@ -9,18 +9,26 @@ assert.notStrictEqual(process.cwd(), __dirname);
process.chdir(__dirname); process.chdir(__dirname);
assert.strictEqual(process.cwd(), __dirname); assert.strictEqual(process.cwd(), __dirname);
const dir = path.resolve(common.tmpDir, let dirName;
'weird \uc3a4\uc3ab\uc3af characters \u00e1\u00e2\u00e3'); if (process.versions.icu) {
// ICU is available, use characters that could possibly be decomposed
dirName = 'weird \uc3a4\uc3ab\uc3af characters \u00e1\u00e2\u00e3';
} else {
// ICU is unavailable, use characters that can't be decomposed
dirName = 'weird \ud83d\udc04 characters \ud83d\udc05';
}
const dir = path.resolve(common.tmpDir, dirName);
// Make sure that the tmp directory is clean // Make sure that the tmp directory is clean
common.refreshTmpDir(); common.refreshTmpDir();
fs.mkdirSync(dir); fs.mkdirSync(dir);
process.chdir(dir); process.chdir(dir);
assert.strictEqual(process.cwd(), dir); assert.strictEqual(process.cwd().normalize(), dir.normalize());
process.chdir('..'); process.chdir('..');
assert.strictEqual(process.cwd(), path.resolve(common.tmpDir)); assert.strictEqual(process.cwd().normalize(),
path.resolve(common.tmpDir).normalize());
assert.throws(function() { process.chdir({}); }, TypeError, 'Bad argument.'); assert.throws(function() { process.chdir({}); }, TypeError, 'Bad argument.');
assert.throws(function() { process.chdir(); }, TypeError, 'Bad argument.'); assert.throws(function() { process.chdir(); }, TypeError, 'Bad argument.');

Loading…
Cancel
Save