Browse Source

src,tools: remove null sentinel from source array

PR-URL: https://github.com/nodejs/node/pull/5418
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
v4.x
Ben Noordhuis 9 years ago
committed by Myles Borins
parent
commit
e0eebf412e
  1. 15
      src/node_javascript.cc
  2. 8
      tools/js2c.py

15
src/node_javascript.cc

@ -4,11 +4,6 @@
#include "env.h"
#include "env-inl.h"
#include <string.h>
#if !defined(_MSC_VER)
#include <strings.h>
#endif
namespace node {
using v8::HandleScope;
@ -26,13 +21,13 @@ Local<String> MainSource(Environment* env) {
void DefineJavaScript(Environment* env, Local<Object> target) {
HandleScope scope(env->isolate());
for (int i = 0; natives[i].name; i++) {
if (natives[i].source != node_native) {
Local<String> name = String::NewFromUtf8(env->isolate(), natives[i].name);
for (auto native : natives) {
if (native.source != node_native) {
Local<String> name = String::NewFromUtf8(env->isolate(), native.name);
Local<String> source =
String::NewFromUtf8(
env->isolate(), reinterpret_cast<const char*>(natives[i].source),
NewStringType::kNormal, natives[i].source_len).ToLocalChecked();
env->isolate(), reinterpret_cast<const char*>(native.source),
NewStringType::kNormal, native.source_len).ToLocalChecked();
target->Set(name, source);
}
}

8
tools/js2c.py

@ -207,13 +207,7 @@ struct _native {
size_t source_len;
};
static const struct _native natives[] = {
%(native_lines)s\
{ NULL, NULL, 0 } /* sentinel */
};
static const struct _native natives[] = { %(native_lines)s };
}
#endif

Loading…
Cancel
Save