Browse Source
test: run the addon tests last
Running the addon tests before the parallel, sequential, etc. tests
can be a problem if there is a bug in node that prevents the
addon tests from running properly. When the addon tests fail for any
reason, then none of the other tests (e.g. parallel, etc.)
are executed.
Running the addon tests last fixes this.
Refs: https://github.com/nodejs/node/issues/12031
PR-URL: https://github.com/nodejs/node/pull/12062
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Sebastian Van Sande
8 years ago
Myles Borins
GPG Key ID:
2 changed files with
4 additions and
4 deletions
Makefile
vcbuild.bat
@ -122,7 +122,7 @@ test: all
$( MAKE) build-addons
$( MAKE) cctest
$( PYTHON) tools/test.py --mode= release -J \
addons doctool inspector known_issues message pseudo-tty parallel sequential
doctool inspector known_issues message pseudo-tty parallel sequential addons
$( MAKE) lint
test-parallel : all
@ -232,7 +232,7 @@ test-ci: | clear-stalled build-addons
out/Release/cctest --gtest_output= tap:cctest.tap
$( PYTHON) tools/test.py $( PARALLEL_ARGS) -p tap --logfile test.tap \
--mode= release --flaky-tests= $( FLAKY_TESTS) \
$( TEST_CI_ARGS) $( CI_NATIVE_SUITES) $( CI_JS _SUITES)
$( TEST_CI_ARGS) $( CI_JS_SUITES) $( CI_NATIVE _SUITES)
# Clean up any leftover processes, error if found.
ps awwx | grep Release/node | grep -v grep | cat
@PS_OUT= ` ps awwx | grep Release/node | grep -v grep | awk '{print $$1}' ` ; \
@ -56,8 +56,8 @@ if /i "%1"=="nosnapshot" set nosnapshot=1&goto arg-ok
if /i " %1 " == " noetw " set noetw = 1& goto arg-ok
if /i " %1 " == " noperfctr " set noperfctr = 1& goto arg-ok
if /i " %1 " == " licensertf " set licensertf = 1& goto arg-ok
if /i " %1 " == " test " set test_args = %test_args% addons doctool known_issues message parallel sequential -J& set jslint = 1& set build_addons = 1& goto arg-ok
if /i " %1 " == " test-ci " set test_args = %test_args% %test_ci_args% -p tap --logfile test.tap addons doctool inspector known_issues message sequential parallel& set cctest_args = %cctest_args% --gtest_output=tap:cctest.tap& set build_addons = 1& goto arg-ok
if /i " %1 " == " test " set test_args = %test_args% doctool known_issues message parallel sequential addons -J& set jslint = 1& set build_addons = 1& goto arg-ok
if /i " %1 " == " test-ci " set test_args = %test_args% %test_ci_args% -p tap --logfile test.tap doctool inspector known_issues message sequential parallel addons & set cctest_args = %cctest_args% --gtest_output=tap:cctest.tap& set build_addons = 1& goto arg-ok
if /i " %1 " == " test-addons " set test_args = %test_args% addons& set build_addons = 1& goto arg-ok
if /i " %1 " == " test-simple " set test_args = %test_args% sequential parallel -J& goto arg-ok
if /i " %1 " == " test-message " set test_args = %test_args% message& goto arg-ok
Sebastian Van Sande
8 years ago
Myles Borins