Browse Source

test: dynamic port in parallel regress tests

Removed common.PORT from test-regress-GH-5051 and
test-regress-GH-5727 in order to eliminate the possibility
of port collision.

Refs: https://github.com/nodejs/node/issues/12376
PR-URL: https://github.com/nodejs/node/pull/12639
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
v6
Sebastian Plesciuc 8 years ago
committed by Anna Henningsen
parent
commit
e927809eec
No known key found for this signature in database GPG Key ID: D8B9F5AEAE84E4CF
  1. 10
      test/parallel/test-regress-GH-5051.js
  2. 4
      test/parallel/test-regress-GH-5727.js

10
test/parallel/test-regress-GH-5051.js

@ -12,20 +12,22 @@ agent.maxSockets = 0;
// localAddress is used when naming requests / sockets // localAddress is used when naming requests / sockets
// while using the Legacy API // while using the Legacy API
agent.addRequest(req, 'localhost', common.PORT, '127.0.0.1'); // port 8080 is hardcoded since this does not create a network connection
agent.addRequest(req, 'localhost', 8080, '127.0.0.1');
assert.strictEqual(Object.keys(agent.requests).length, 1); assert.strictEqual(Object.keys(agent.requests).length, 1);
assert.strictEqual( assert.strictEqual(
Object.keys(agent.requests)[0], Object.keys(agent.requests)[0],
'localhost:' + common.PORT + ':127.0.0.1'); 'localhost:8080:127.0.0.1');
// path is *not* used when naming requests / sockets // path is *not* used when naming requests / sockets
// port 8080 is hardcoded since this does not create a network connection
agent.addRequest(req, { agent.addRequest(req, {
host: 'localhost', host: 'localhost',
port: common.PORT, port: 8080,
localAddress: '127.0.0.1', localAddress: '127.0.0.1',
path: '/foo' path: '/foo'
}); });
assert.strictEqual(Object.keys(agent.requests).length, 1); assert.strictEqual(Object.keys(agent.requests).length, 1);
assert.strictEqual( assert.strictEqual(
Object.keys(agent.requests)[0], Object.keys(agent.requests)[0],
'localhost:' + common.PORT + ':127.0.0.1'); 'localhost:8080:127.0.0.1');

4
test/parallel/test-regress-GH-5727.js

@ -6,9 +6,9 @@ const net = require('net');
const invalidPort = -1 >>> 0; const invalidPort = -1 >>> 0;
const errorMessage = /"port" argument must be >= 0 and < 65536/; const errorMessage = /"port" argument must be >= 0 and < 65536/;
net.Server().listen(common.PORT, function() { net.Server().listen(0, function() {
const address = this.address(); const address = this.address();
const key = `${address.family.slice(-1)}:${address.address}:${common.PORT}`; const key = `${address.family.slice(-1)}:${address.address}:0`;
assert.strictEqual(this._connectionKey, key); assert.strictEqual(this._connectionKey, key);
this.close(); this.close();

Loading…
Cancel
Save