From eb3fee1b87baa85c7792bf1e01cac4396db6dd14 Mon Sep 17 00:00:00 2001 From: Bradley Farias Date: Thu, 12 Oct 2017 08:33:39 -0500 Subject: [PATCH] doc: ensure collaborators validate commits MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This should be done every time a collaborator pushes a commit. PR-URL: https://github.com/nodejs/node/pull/16162 Reviewed-By: Joyee Cheung Reviewed-By: Anna Henningsen Reviewed-By: Luigi Pinca Reviewed-By: Roman Reiss Reviewed-By: Jeremiah Senkpiel Reviewed-By: Tobias Nießen Reviewed-By: Colin Ihrig Reviewed-By: James M Snell Reviewed-By: Michael Dawson Reviewed-By: Gibson Fahnestock Reviewed-By: Evan Lucas --- COLLABORATOR_GUIDE.md | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index f60eba21aa..e96585f4fd 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -517,6 +517,13 @@ Run tests (`make -j4 test` or `vcbuild test`). Even though there was a successful continuous integration run, other changes may have landed on master since then, so running the tests one last time locally is a good practice. +Validate that the commit message is properly formatted using +[core-validate-commit](https://github.com/evanlucas/core-validate-commit). + +```text +$ git rev-list upstream/master...HEAD | xargs core-validate-commit +``` + Time to push it: ```text