From ed74db01f35c525d90a5d1ec93f96a7602ca2711 Mon Sep 17 00:00:00 2001 From: Ryan Dahl Date: Wed, 30 Mar 2011 15:53:07 -0700 Subject: [PATCH] process.stderr.write should return true --- src/node_stdio.cc | 9 ++++----- test/simple/test-console.js | 3 +++ 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/src/node_stdio.cc b/src/node_stdio.cc index 00bdd86506..f744e3f7cf 100644 --- a/src/node_stdio.cc +++ b/src/node_stdio.cc @@ -165,13 +165,12 @@ static Handle IsATTY (const Arguments& args) { /* STDERR IS ALWAY SYNC ALWAYS UTF8 */ -static Handle -WriteError (const Arguments& args) -{ +static Handle WriteError (const Arguments& args) { HandleScope scope; - if (args.Length() < 1) + if (args.Length() < 1) { return Undefined(); + } String::Utf8Value msg(args[0]->ToString()); @@ -189,7 +188,7 @@ WriteError (const Arguments& args) written += (size_t)r; } - return Undefined(); + return True(); } diff --git a/test/simple/test-console.js b/test/simple/test-console.js index adde7246b1..b7def76c40 100644 --- a/test/simple/test-console.js +++ b/test/simple/test-console.js @@ -36,3 +36,6 @@ global.process.stdout.write = stdout_write; assert.equal('foo\n', strings.shift()); assert.equal('foo bar\n', strings.shift()); assert.equal('foo bar hop\n', strings.shift()); + + +assert.equal(true, process.stderr.write("hello world"));