From f0c1376e07e6d5a4deb3d088bd3153d7f6af1298 Mon Sep 17 00:00:00 2001
From: Ben Noordhuis <info@bnoordhuis.nl>
Date: Sat, 14 Jan 2012 02:13:22 +0100
Subject: [PATCH] net: make .write() throw on bad input

Passing a non-buffer or non-string argument to Socket.prototype.write triggered
an assert:

  Assertion failed: (Buffer::HasInstance(args[0])), function Write,
  file ../src/stream_wrap.cc, line 289.

Fixes #2532.
---
 lib/net.js                             |  4 +++-
 test/simple/test-net-connect-buffer.js | 19 +++++++++++++++++++
 2 files changed, 22 insertions(+), 1 deletion(-)

diff --git a/lib/net.js b/lib/net.js
index 072896b4c4..85479412b2 100644
--- a/lib/net.js
+++ b/lib/net.js
@@ -424,8 +424,10 @@ Socket.prototype.write = function(data, arg1, arg2) {
   }
 
   // Change strings to buffers. SLOW
-  if (typeof data == 'string') {
+  if (typeof data === 'string') {
     data = new Buffer(data, encoding);
+  } else if (!Buffer.isBuffer(data)) {
+    throw new TypeError("First argument must be a buffer or a string.");
   }
 
   this.bytesWritten += data.length;
diff --git a/test/simple/test-net-connect-buffer.js b/test/simple/test-net-connect-buffer.js
index 9fbf18c839..75486af974 100644
--- a/test/simple/test-net-connect-buffer.js
+++ b/test/simple/test-net-connect-buffer.js
@@ -63,6 +63,25 @@ tcp.listen(common.PORT, function() {
 
   assert.equal('opening', socket.readyState);
 
+  // Make sure that anything besides a buffer or a string throws.
+  [ null,
+    true,
+    false,
+    undefined,
+    1,
+    1.0,
+    1 / 0,
+    +Infinity
+    -Infinity,
+    [],
+    {}
+  ].forEach(function(v) {
+    function f() {
+      socket.write(v);
+    }
+    assert.throws(f, TypeError);
+  });
+
   // Write a string that contains a multi-byte character sequence to test that
   // `bytesWritten` is incremented with the # of bytes, not # of characters.
   var a = "L'État, c'est ";