From f64989e63b9cf11c88e46b422de6234fc4699039 Mon Sep 17 00:00:00 2001 From: Christopher Jeffrey Date: Thu, 2 Feb 2012 00:44:22 -0600 Subject: [PATCH] fs: fix ReadStream fails to read from existing fd A ReadStream constructed from an existing file descriptor failed to start reading automatically. Avoids a userspace call to ReadStream.prototype._read(). --- lib/fs.js | 1 + test/simple/test-fs-read-stream-fd.js | 44 +++++++++++++++++++++++++++ 2 files changed, 45 insertions(+) create mode 100644 test/simple/test-fs-read-stream-fd.js diff --git a/lib/fs.js b/lib/fs.js index 7b61c8984c..3603232abf 100644 --- a/lib/fs.js +++ b/lib/fs.js @@ -1050,6 +1050,7 @@ var ReadStream = fs.ReadStream = function(path, options) { } if (this.fd !== null) { + this._read(); return; } diff --git a/test/simple/test-fs-read-stream-fd.js b/test/simple/test-fs-read-stream-fd.js new file mode 100644 index 0000000000..835ed97271 --- /dev/null +++ b/test/simple/test-fs-read-stream-fd.js @@ -0,0 +1,44 @@ +// Copyright Joyent, Inc. and other Node contributors. +// +// Permission is hereby granted, free of charge, to any person obtaining a +// copy of this software and associated documentation files (the +// "Software"), to deal in the Software without restriction, including +// without limitation the rights to use, copy, modify, merge, publish, +// distribute, sublicense, and/or sell copies of the Software, and to permit +// persons to whom the Software is furnished to do so, subject to the +// following conditions: +// +// The above copyright notice and this permission notice shall be included +// in all copies or substantial portions of the Software. +// +// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS +// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF +// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN +// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, +// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR +// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE +// USE OR OTHER DEALINGS IN THE SOFTWARE. + +var fs = require('fs'); +var assert = require('assert'); +var path = require('path'); + +var common = require('../common'); + +var file = path.join(common.tmpDir, '/read_stream_fd_test.txt'); +var input = 'hello world'; +var output = ''; +var fd, stream; + +fs.writeFileSync(file, input); +fd = fs.openSync(file, 'r'); + +stream = fs.createReadStream(null, { fd: fd, encoding: 'utf8' }); +stream.on('data', function(data) { + output += data; +}); + +process.on('exit', function() { + fs.unlinkSync(file); + assert.equal(output, input); +});