From f651e4035026feb4cf2fc70b0a4f0a6be9d92862 Mon Sep 17 00:00:00 2001 From: Daniel Bevenius Date: Wed, 5 Jul 2017 05:35:50 +0200 Subject: [PATCH] test: check and fail inspector-cluster-port-clash Currently this test fail when configured --without-inspector or --without-ssl as it is expected to fail but the skipIfInspectorDisabled check will exit as if the test was sucessful. This commit checks if inspector support is available and fails the test allowing the test to be skipped. PR-URL: https://github.com/nodejs/node/pull/14074 Reviewed-By: Colin Ihrig Reviewed-By: Refael Ackermann --- .../known_issues/test-inspector-cluster-port-clash.js | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/test/known_issues/test-inspector-cluster-port-clash.js b/test/known_issues/test-inspector-cluster-port-clash.js index 41b00aacc1..9fa2b48356 100644 --- a/test/known_issues/test-inspector-cluster-port-clash.js +++ b/test/known_issues/test-inspector-cluster-port-clash.js @@ -1,6 +1,7 @@ // Flags: --inspect=0 'use strict'; const common = require('../common'); +const assert = require('assert'); // With the current behavior of Node.js (at least as late as 8.1.0), this // test fails with the following error: @@ -10,9 +11,15 @@ const common = require('../common'); // // Refs: https://github.com/nodejs/node/issues/13343 -common.skipIfInspectorDisabled(); +// This following check should be replaced by common.skipIfInspectorDisabled() +// if moved out of the known_issues directory. +if (process.config.variables.v8_enable_inspector === 0) { + // When the V8 inspector is disabled, using either --without-inspector or + // --without-ssl, this test will not fail which it is expected to do. + // The following fail will allow this test to be skipped by failing it. + assert.fail('skipping as V8 inspector is disabled'); +} -const assert = require('assert'); const cluster = require('cluster'); const net = require('net');