Browse Source

test: improve http test reliability

Fake the socket handle to ensure an immediate error is returned
uniformly across all platforms.

PR-URL: https://github.com/nodejs/node/pull/13693
Reviewed-By: James M Snell <jasnell@gmail.com>
v6
Brian White 8 years ago
parent
commit
fcd82e7601
No known key found for this signature in database GPG Key ID: 606D7358F94DA209
  1. 34
      test/parallel/test-http-client-immediate-error.js

34
test/parallel/test-http-client-immediate-error.js

@ -5,8 +5,36 @@
const common = require('../common');
const assert = require('assert');
const net = require('net');
const http = require('http');
const req = http.get({ host: '127.0.0.1', port: 1 });
req.on('error', common.mustCall((err) => {
assert.strictEqual(err.code, 'ECONNREFUSED');
const uv = process.binding('uv');
const { async_id_symbol } = process.binding('async_wrap');
const { newUid } = require('async_hooks');
const agent = new http.Agent();
agent.createConnection = common.mustCall((cfg) => {
const sock = new net.Socket();
// Fake the handle so we can enforce returning an immediate error
sock._handle = {
connect: common.mustCall((req, addr, port) => {
return uv.UV_ENETUNREACH;
}),
readStart() {},
close() {}
};
// Simulate just enough socket handle initialization
sock[async_id_symbol] = newUid();
sock.connect(cfg);
return sock;
});
http.get({
host: '127.0.0.1',
port: 1,
agent
}).on('error', common.mustCall((err) => {
assert.strictEqual(err.code, 'ENETUNREACH');
}));

Loading…
Cancel
Save