mirror of https://github.com/lukechilds/node.git
Browse Source
Currently when running configure with the --debug option in combination with the tests (./configure --debug && make -j8 test) there are a few addon tests that fail with error messages similar to this: === release test === Path: addons/load-long-path/test fs.js:558 return binding.open(pathModule._makeLong(path), stringToFlags(flags), mode); ^ Error: ENOENT: no such file or directory, open '/nodejs/node/test/addons/load-long-path/build/Release/binding.node' at Object.fs.openSync (fs.js:558:18) at Object.fs.readFileSync (fs.js:468:33) at Object.<anonymous> (/nodejs/node/test/addons/load-long-path/test.js:28:19) at Module._compile (module.js:560:32) at Object.Module._extensions..js (module.js:569:10) at Module.load (module.js:477:32) at tryModuleLoad (module.js:436:12) at Function.Module._load (module.js:428:3) at Module.runMain (module.js:594:10) at run (bootstrap_node.js:382:7) Command: out/Release/node /nodejs/node/test/addons/load-long-path/test.js This commit allows for the tests to pass even if the configured build type is of type debug. PR-URL: https://github.com/nodejs/node/pull/8836 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>v6
Daniel Bevenius
8 years ago
committed by
James M Snell
24 changed files with 37 additions and 33 deletions
@ -1,3 +1,3 @@ |
|||
'use strict'; |
|||
require('../../common'); |
|||
require('./build/Release/binding'); |
|||
const common = require('../../common'); |
|||
require(`./build/${common.buildType}/binding`); |
|||
|
@ -1,6 +1,6 @@ |
|||
'use strict'; |
|||
require('../../common'); |
|||
const common = require('../../common'); |
|||
var assert = require('assert'); |
|||
var binding = require('./build/Release/binding'); |
|||
const binding = require(`./build/${common.buildType}/binding`); |
|||
assert.equal('world', binding()); |
|||
console.log('binding.hello() =', binding()); |
|||
|
@ -1,6 +1,6 @@ |
|||
'use strict'; |
|||
require('../../common'); |
|||
const common = require('../../common'); |
|||
var assert = require('assert'); |
|||
var binding = require('./build/Release/binding'); |
|||
const binding = require(`./build/${common.buildType}/binding`); |
|||
assert.equal('world', binding.hello()); |
|||
console.log('binding.hello() =', binding.hello()); |
|||
|
@ -1,7 +1,7 @@ |
|||
'use strict'; |
|||
// Flags: --expose-gc
|
|||
|
|||
require('../../common'); |
|||
var binding = require('./build/Release/binding'); |
|||
const common = require('../../common'); |
|||
const binding = require(`./build/${common.buildType}/binding`); |
|||
|
|||
binding.run(); |
|||
|
@ -1,8 +1,8 @@ |
|||
'use strict'; |
|||
|
|||
require('../../common'); |
|||
const common = require('../../common'); |
|||
const assert = require('assert'); |
|||
const binding = require('./build/Release/binding'); |
|||
const binding = require(`./build/${common.buildType}/binding`); |
|||
const bytes = new Uint8Array(1024); |
|||
assert(binding.randomBytes(bytes)); |
|||
assert(bytes.reduce((v, a) => v + a) > 0); |
|||
|
Loading…
Reference in new issue