lukechilds/node - node - Gitea: Git with a cup of tea

Branch: v0.11.15-release

Author	SHA1	Message	Date
Alexis Campailla	0f10dd4cb2	test: increase timeout in readable stream test A slightly higher timeout is needed for the test to pass on Windows debug builds.	11 years ago
isaacs	88644eaa2d	stream: There is no _read cb, there is only push This makes it so that `stream.push(chunk)` is the only way to signal the end of reading, removing the confusing disparity between the callback-style _read method, and the fact that most real-world streams do not have a 1:1 corollation between the "please give me data" event, and the actual arrival of a chunk of data. It is still possible, of course, to implement a `CallbackReadable` on top of this. Simply provide a method like this as the callback: function readCallback(er, chunk) { if (er) stream.emit('error', er); else stream.push(chunk); } However, only fs streams actually would behave in this way, so it makes not a lot of sense to make TCP, TLS, HTTP, and all the rest have to bend into this uncomfortable paradigm.	12 years ago
isaacs	a6c18472cd	stream: Don't stop reading on zero-length decoded output Fixes regression introduced in `7e1cf84c9e`	12 years ago
isaacs	7e1cf84c9e	stream: Don't signal EOF on '' or Buffer(0) Those values, if passed to the _read() cb, will not signal an EOF. Only null or undefined will mark the end of data, and trigger the end event. However, great care must be taken if you are returning an empty string or buffer! There must be some other thing somewhere that will trigger a read() call, because there will never be a readable event fired later. This is in preparation for CryptoStreams being ported to streams2, where it is safe to simply stop reading, because the crypto cycle process will cause it to read(0) again at some future date.	12 years ago