lukechilds/node - node - Gitea: Git with a cup of tea

Author	SHA1	Message	Date
James Halliday	8e2cc69e78	stream: fix Readable.wrap objectMode falsy values A streams1 stream will have its falsy values such as 0, false, or "" eaten by the upgrade to streams2, even when objectMode is enabled. Include test for said cases. Reviewed-by: isaacs <i@izs.me> Reviewed-by: Trevor Norris <trev.norris@gmail.com>	11 years ago
isaacs	0f8de5e1f9	stream: Simplify flowing, passive data listening Closes #5860 In streams2, there is an "old mode" for compatibility. Once switched into this mode, there is no going back. With this change, there is a "flowing mode" and a "paused mode". If you add a data listener, then this will start the flow of data. However, hitting the `pause()` method will switch back into a non-flowing mode, where the `read()` method will pull data out. Every time `read()` returns a data chunk, it also emits a `data` event. In this way, a passive data listener can be added, and the stream passed off to some other reader, for use with progress bars and the like. There is no API change beyond this added flexibility.	12 years ago
Daniel Moore	1ad93a6584	stream: make Readable.wrap support objectMode Added a check to see if the stream is in objectMode before deciding whether to include or exclude data from an old-style wrapped stream.	12 years ago
isaacs	14947b6c5e	stream: Return self from readable.wrap Also, set paused=false before calling resume(). Otherwise, there's an edge case where an immediately-emitted chunk might make it call pause() again incorrectly.	12 years ago
isaacs	88644eaa2d	stream: There is no _read cb, there is only push This makes it so that `stream.push(chunk)` is the only way to signal the end of reading, removing the confusing disparity between the callback-style _read method, and the fact that most real-world streams do not have a 1:1 corollation between the "please give me data" event, and the actual arrival of a chunk of data. It is still possible, of course, to implement a `CallbackReadable` on top of this. Simply provide a method like this as the callback: function readCallback(er, chunk) { if (er) stream.emit('error', er); else stream.push(chunk); } However, only fs streams actually would behave in this way, so it makes not a lot of sense to make TCP, TLS, HTTP, and all the rest have to bend into this uncomfortable paradigm.	12 years ago
isaacs	a63c28e6eb	stream: Return false from push() more properly There are cases where a push() call would return true, even though the thing being pushed was in fact way way larger than the high water mark, simply because the 'needReadable' was already set, and would not get unset until nextTick. In some cases, this could lead to an infinite loop of pushing data into the buffer, never getting to the 'readable' event which would unset the needReadable flag. Fix by splitting up the emitReadable function, so that it always sets the flag on this tick, even if it defers until nextTick to actually emit the event. Also, if we're not ending or already in the process of reading, it now calls read(0) if we're below the high water mark. Thus, the highWaterMark value is the intended amount to buffer up to, and it is smarter about hitting the target.	12 years ago
isaacs	782149ddc3	streams2: Handle sync read callbacks nicely	12 years ago
Timothy J Fontaine	77945d7f0f	add unref/ref tests for socket/server/timers	13 years ago
Ben Noordhuis	03eb41c2ec	net: don't emit 'close' event twice Don't allow `socket.destroy()` to run twice. The self-destruct sequence itself is idempotent but it makes the 'close' and 'error' events fire more than once, which may confuse listeners. Fixes #2223.	13 years ago
Ben Noordhuis	9c11e8a1ca	net: implement Server.prototype.address() for pipes	13 years ago
koichik	d6191f593d	net: fix error handling in listen() Fixes #1894.	13 years ago
Ryan Dahl	4e1d6fca8e	Mark tests which are broken in libuv	14 years ago
Felix Geisendörfer	09ee29318f	Emit 'close' after all connections have closed Fixes #1383	14 years ago
Ryan Dahl	55048cdf79	Update copyright headers	14 years ago
koichik	113b1e6e0c	Fix GH-746 process.stdin.destroy() breaks http server	14 years ago