lukechilds/node - node - Gitea: Git with a cup of tea

Author	SHA1	Message	Date
Santiago Gimeno	7c88410507	test: fix child-process-fork-regr-gh-2847 again Windows is still sometimes failing with ECONNRESET. Bring back the handling of this error as was initially introduced in PR #4442. PR-URL: https://github.com/nodejs/node/pull/5179 Reviewed-By: Rich Trott <rtrott@gmail.com> Fixes: https://github.com/nodejs/node/issues/3635	9 years ago
Santiago Gimeno	8301773c1e	test: fix child-process-fork-regr-gh-2847 The test would sometimes time out on some platforms. Take the initial version of the test and instead of sending 100 handles, just send 2. It still fails when run with the code before the change was introduced and passes afterwards. Remove test from parallel.status. PR-URL: https://github.com/nodejs/node/pull/5121 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Fixes: https://github.com/nodejs/node/issues/3635	9 years ago
Brian White	03c4bc704f	test: fix flaky child-process-fork-regr-gh-2847 Windows would die with ECONNRESET most times when running this particular test. This commit makes handling these errors more tolerable. PR-URL: https://github.com/nodejs/node/pull/4442 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>	9 years ago
Rich Trott	3710028a85	test: remove unused `util` imports A number of tests in `test/parallel` were importing the `util` module via `require()` but not using `util` for anything. This removes those `require()` statements. PR-URL: https://github.com/nodejs/node/pull/4397 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>	9 years ago
Michael Dawson	7c35fbcb14	test: harden test-child-process-fork-regr-gh-2847 test-child-process-fork-regr-gh-2847 could fail depending on timing and how messages were packed into tcp packets. If all of the requests fit into one packet then the test worked otherwise, otherwise errors could occur. This PR modifies the test to be tolerant while still validating that some of the connection can be made succesfully Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/3459	10 years ago
Fedor Indutny	36b969ff44	child_process: `null` channel handle on close `HandleWrap::OnClose` destroys the underlying C++ object and null's the internal field pointer to it. Therefore there should be no references to the wrapping JavaScript object. `null` the process' `_channel` field right after closing it, to ensure no crashes will happen. Fix: https://github.com/nodejs/node/issues/2847 PR-URL: https://github.com/nodejs/node/pull/3041 Reviewed-By: Trevor Norris <trev.norris@gmail.com>	10 years ago