lukechilds/node - node - Gitea: Git with a cup of tea

16407 Commits

131 Branches

446 Tags

325 MiB

Tree: 0593528241

Commit Graph

Author	SHA1	Message	Date
Santiago Gimeno	793d8719eb	test: fix flaky test-debug-port It can happen that first data chunk received in stdout is not exactly `'debug> '`. Make sure the exit condition is met. PR-URL: https://github.com/nodejs/node/pull/10316 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com>	8 years ago
Lance Ball	6410534ec1	debugger: call `this.resume()` after `this.run()` When the debugger has started we need to call `this.resume` otherwise, the prompt won't appear. Fixes: https://github.com/nodejs/node/issues/9854 PR-URL: https://github.com/nodejs/node/pull/10099 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com>	8 years ago

Author

SHA1

Message

Date

Santiago Gimeno

793d8719eb

test: fix flaky test-debug-port

It can happen that first data chunk received in stdout is not exactly
`'debug> '`. Make sure the exit condition is met.

PR-URL: https://github.com/nodejs/node/pull/10316
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>

8 years ago

Lance Ball

6410534ec1

debugger: call `this.resume()` after `this.run()`

When the debugger has started we need to call `this.resume` otherwise,
the prompt won't appear.

Fixes: https://github.com/nodejs/node/issues/9854
PR-URL: https://github.com/nodejs/node/pull/10099
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>

8 years ago

2 Commits (059352824103cc928048d3eefeaa23340400fc87)