lukechilds/node - node - Gitea: Git with a cup of tea

13874 Commits

131 Branches

446 Tags

325 MiB

Tree: 06a1c9bf80

Commit Graph

Author	SHA1	Message	Date
Rich Trott	7c79490bfb	test: only refresh tmpDir for tests that need it Expose `common.refreshTmpDir()` and only call it for tests that use common.tmpDir or common.PIPE. A positive side effect is the removal of a code smell where child processes were detected by the presence of `.send()`. Now each process can decide for itself if it needs to refresh tmpDir. PR-URL: https://github.com/nodejs/io.js/pull/1954 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>	10 years ago
Yosuke Furukawa	8357c5084b	fs: set encoding on fs.createWriteStream Enable encoding option on fs.createWriteStream. PR-URL: https://github.com/nodejs/io.js/pull/1844 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>	10 years ago

Author

SHA1

Message

Date

Rich Trott

7c79490bfb

test: only refresh tmpDir for tests that need it

Expose `common.refreshTmpDir()` and only call it
for tests that use common.tmpDir or common.PIPE.

A positive side effect is the removal of a code
smell where child processes were detected by the
presence of `.send()`. Now each process can decide
for itself if it needs to refresh tmpDir.

PR-URL: https://github.com/nodejs/io.js/pull/1954
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>

10 years ago

Yosuke Furukawa

8357c5084b

fs: set encoding on fs.createWriteStream

Enable encoding option on fs.createWriteStream.

PR-URL: https://github.com/nodejs/io.js/pull/1844
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

10 years ago

2 Commits (06a1c9bf80a4ea4ea1107ca425051cd679c8b40b)