lukechilds/node - node - Gitea: Git with a cup of tea

19178 Commits

131 Branches

446 Tags

325 MiB

Tree: 07f1efc2ae

Commit Graph

Author	SHA1	Message	Date
Ruben Bridgewater	1b54371c50	stream: use more explicit statements Using objectMode with stream_wrap has not worked properly before and would end in an error. Therefore prohibit the usage of objectMode alltogether. This also improves the handling performance due to the cheaper chunk check and by using explicit statements as they produce better code from the compiler. PR-URL: https://github.com/nodejs/node/pull/13863 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>	8 years ago
Fedor Indutny	de2fd63612	stream_wrap: error if stream has StringDecoder If `.setEncoding` was called on input stream - all emitted `data` will be `String`s instances, not `Buffer`s. This is unacceptable for `StreamWrap`, and should not lead to the crash. Fix: https://github.com/nodejs/node/issues/3970 PR-URL: https://github.com/nodejs/node/pull/4031 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>	9 years ago

Author

SHA1

Message

Date

Ruben Bridgewater

1b54371c50

stream: use more explicit statements

Using objectMode with stream_wrap has not worked properly
before and would end in an error.
Therefore prohibit the usage of objectMode alltogether.

This also improves the handling performance due to the
cheaper chunk check and by using explicit statements as they
produce better code from the compiler.

PR-URL: https://github.com/nodejs/node/pull/13863
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

8 years ago

Fedor Indutny

de2fd63612

stream_wrap: error if stream has StringDecoder

If `.setEncoding` was called on input stream - all emitted `data` will
be `String`s instances, not `Buffer`s. This is unacceptable for
`StreamWrap`, and should not lead to the crash.

Fix: https://github.com/nodejs/node/issues/3970
PR-URL: https://github.com/nodejs/node/pull/4031
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

9 years ago

2 Commits (07f1efc2aeb68d993c8e132e3c3c52881c7f6670)