lukechilds/node - node - Gitea: Git with a cup of tea

16240 Commits

131 Branches

446 Tags

325 MiB

Tree: 12287f1299

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Myles Borins	bed6acb1ed	Revert "src: fix delete operator on vm context" This reverts commit `587857e301`. It was found to have subtle behavior changes in deleting objects. PR-URL: https://github.com/nodejs/node/pull/12721 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>	8 years ago
Franziska Hinkelmann	587857e301	src: fix delete operator on vm context In the implementation of the vm module, if a property is successfully deleted on the sandbox, we also need to delete it on the global_proxy object. Therefore, we must not call args.GetReturnValue().Set(). We only intercept, i.e., call args.GetReturnValue().Set(), in the DeleterCallback, if Delete() failed, e.g. because the property was read only. PR-URL: https://github.com/nodejs/node/pull/11266 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>	8 years ago
AnnaMag	c604016cb4	test: add known_issues test for #6287 Deleting property in the vm context has no effect as reported in https://github.com/nodejs/node/issues/6287 The test is moved to the known_issues and will be fixed with the 5.5 V8 API changes. PR-URL: https://github.com/nodejs/node/pull/10272 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>	8 years ago

Myles Borins

bed6acb1ed

Revert "src: fix delete operator on vm context"

This reverts commit 587857e301. It was found to have subtle
behavior changes in deleting objects.

PR-URL: https://github.com/nodejs/node/pull/12721
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

8 years ago

Franziska Hinkelmann

587857e301

src: fix delete operator on vm context

In the implementation of the vm module,
if a property is successfully deleted
on the sandbox, we also need to delete it
on the global_proxy object. Therefore, we
must not call args.GetReturnValue().Set().

We only intercept, i.e., call
args.GetReturnValue().Set(), in the
DeleterCallback, if Delete() failed, e.g. because
the property was read only.

PR-URL: https://github.com/nodejs/node/pull/11266
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

8 years ago

AnnaMag

c604016cb4

test: add known_issues test for #6287

Deleting property in the vm context has no effect
as reported in https://github.com/nodejs/node/issues/6287
The test is moved to the known_issues and will be fixed
with the 5.5 V8 API changes.

PR-URL: https://github.com/nodejs/node/pull/10272
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

8 years ago

3 Commits (12287f1299f41db78236dbd6de7637320c83c6b1)