lukechilds/node - node - Gitea: Git with a cup of tea

17662 Commits

131 Branches

446 Tags

325 MiB

Tree: 17e10b33c2

Commit Graph

Author	SHA1	Message	Date
AnnaMag	7ef2d90e1b	test: fix assertion in vm test Prototypes are not strict equal when they are from different contexts. Therefore, assert.strictEqual() fails for objects that are created in different contexts, e.g., in vm.runInContext(). Instead of expecting the prototypes to be equal, only check the properties of the objects for equality. PR-URL: https://github.com/nodejs/node/pull/11862 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>	8 years ago
cjihrig	10bc673123	test: add batch of known issue tests This commit adds tests for several known issues. Refs: https://github.com/nodejs/node/issues/1901 Refs: https://github.com/nodejs/node/issues/728 Refs: https://github.com/nodejs/node/issues/4778 Refs: https://github.com/nodejs/node/issues/947 Refs: https://github.com/nodejs/node/issues/2734 PR-URL: https://github.com/nodejs/node/pull/5653 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>	9 years ago

Author

SHA1

Message

Date

AnnaMag

7ef2d90e1b

test: fix assertion in vm test

Prototypes are not strict equal when they are from
different contexts. Therefore, assert.strictEqual()
fails for objects that are created in different
contexts, e.g., in vm.runInContext().

Instead of expecting the prototypes to be equal,
only check the properties of the objects
for equality.

PR-URL: https://github.com/nodejs/node/pull/11862
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>

8 years ago

cjihrig

10bc673123

test: add batch of known issue tests

This commit adds tests for several known issues.

Refs: https://github.com/nodejs/node/issues/1901
Refs: https://github.com/nodejs/node/issues/728
Refs: https://github.com/nodejs/node/issues/4778
Refs: https://github.com/nodejs/node/issues/947
Refs: https://github.com/nodejs/node/issues/2734
PR-URL: https://github.com/nodejs/node/pull/5653
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

9 years ago

2 Commits (17e10b33c2c356ab276a98cabd116a8416147f33)