lukechilds/node - node - Gitea: Git with a cup of tea

Author	SHA1	Message	Date
Evan Lucas	da550aa063	repl: make sure historyPath is trimmed If one were to set NODE_REPL_HISTORY to a string that contains only a space (" "), then the history file would be created with that name which can cause problems are certain systems. PR-URL: https://github.com/nodejs/node/pull/4539 Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>	9 years ago
Michaël Zasso	d1aabd6264	test: fix style issues after eslint update Replace var keyword with const or let. PR-URL: https://github.com/nodejs/io.js/pull/2286 Reviewed-By: Roman Reiss <me@silverwind.io>	9 years ago
Rich Trott	3311267f75	test: remove unused `util` imports A number of tests in `test/parallel` were importing the `util` module via `require()` but not using `util` for anything. This removes those `require()` statements. PR-URL: https://github.com/nodejs/node/pull/4397 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>	9 years ago
Mudit Ameta	29c4a2af5c	repl: Fixed node repl history edge case. If the deprecated NODE_REPL_HISTORY_FILE is set to default node history file path ($HOME/.node_repl_history) and the file doesn't exist, then node creates the file and then crashes when it tries to parse that file as JSON thinking that it's an older JSON formatted history file. This fixes that bug. This patch also prevents node repl from throwing if the old history file is empty or if $HOME/.node_repl_history is empty. Fixes: https://github.com/nodejs/node/issues/4102 PR-URL: https://github.com/nodejs/node/pull/4108 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>	9 years ago
Jeremiah Senkpiel	7598ed6cc0	test: parallelize test-repl-persistent-history Refs: https://github.com/nodejs/node/pull/2224#issuecomment-127356413 PR-URL: https://github.com/nodejs/node/pull/4247 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>	9 years ago
Evan Lucas	a4a0efc534	repl: don't crash if cannot open history file Previously, if we are unable to open the history file, an error would be thrown. Now, print an error message that we could not open the history file, but don't fail. Fixes: https://github.com/nodejs/node/issues/3610 PR-URL: https://github.com/nodejs/node/pull/3630 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>	9 years ago
Jeremiah Senkpiel	73b7e052c0	repl: limit persistent history correctly on load Previously the wrong end of the history was limited on load. PR-URL: https://github.com/nodejs/node/pull/2356 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed By: Evan Lucas <evanlucas@me.com>	9 years ago
Jeremiah Senkpiel	286ef1daca	test: cleanup, improve repl-persistent-history - Now cleans up the history file unless told otherwise. - Now also logs which test case failed. - Waits for flush after repl close if necessary. Fixes: https://github.com/nodejs/node/issues/2319 PR-URL: https://github.com/nodejs/node/pull/2356 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed By: Evan Lucas <evanlucas@me.com>	9 years ago
Todd Kennedy	3849750a09	repl: dont throw ENOENT on NODE_REPL_HISTORY_FILE If you have no history file written to disk, but the environment variable set, `fs.readFileSync` will throw an ENOENT error, but there's nothing to convert. The converter should ignore ENOENT on that `fs.readFileSync` call. Fixes: https://github.com/nodejs/node/issues/2449 PR-URL: https://github.com/nodejs/node/pull/2451 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>	10 years ago
Jeremiah Senkpiel	ceee8d2807	test: add tests for persistent repl history PR-URL: https://github.com/nodejs/io.js/pull/2224 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>	10 years ago