lukechilds/node - node - Gitea: Git with a cup of tea

12261 Commits

131 Branches

446 Tags

325 MiB

Tree: 184f09dbe4

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Julien Gilli	9724047268	timers: don't mutate unref list while iterating it Commit `934bfe23a1` had introduced a regression where node would crash trying to access a null unref timer if a given unref timer's callback would remove other unref timers set to fire in the future. More generally, it makes the unrefTimeout function more solid by not mutating the unrefList while traversing it. Fixes: https://github.com/joyent/node/issues/8897 Conflicts: lib/timers.js Fixes: https://github.com/nodejs/node-convergence-archive/issues/23 Ref: https://github.com/nodejs/node/issues/268 PR-URL: https://github.com/nodejs/node/pull/2540 Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>	10 years ago

Julien Gilli

9724047268

timers: don't mutate unref list while iterating it

Commit 934bfe23a1 had introduced a
regression where node would crash trying to access a null unref timer if
a given unref timer's callback would remove other unref timers set to
fire in the future.

More generally, it makes the unrefTimeout function more solid by not
mutating the unrefList while traversing it.

Fixes: https://github.com/joyent/node/issues/8897

Conflicts:
	lib/timers.js

Fixes: https://github.com/nodejs/node-convergence-archive/issues/23
Ref: https://github.com/nodejs/node/issues/268
PR-URL: https://github.com/nodejs/node/pull/2540
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>

10 years ago

1 Commits (184f09dbe4b7dbe244f1085033767d401a9143de)