lukechilds/node - node - Gitea: Git with a cup of tea

17695 Commits

131 Branches

446 Tags

325 MiB

Tree: 1e44fd960f

Commit Graph

Author	SHA1	Message	Date
Ojas Shirekar	2154bc89d8	buffer: fix check for `.buffer` property isSharedArrayBuffer in fromObject was missing obj.buffer moved the 'length' in obj check so that it is checked first making the code slightly more performant and able to handle SharedArrayBuffer without relying on an explicit check. Ref: https://github.com/nodejs/node/pull/8510 PR-URL: https://github.com/nodejs/node/pull/8739 Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>	9 years ago
Ojas Shirekar	2a2ec9dbc3	buffer: add isSharedArrayBuffer checks Fixes: https://github.com/nodejs/node/issues/8440 PR-URL: https://github.com/nodejs/node/pull/8510 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>	9 years ago

Author

SHA1

Message

Date

Ojas Shirekar

2154bc89d8

buffer: fix check for `.buffer` property

isSharedArrayBuffer in fromObject was missing obj.buffer
moved the 'length' in obj check so that it is checked first making
the code slightly more performant and able to handle SharedArrayBuffer
without relying on an explicit check.

Ref: https://github.com/nodejs/node/pull/8510
PR-URL: https://github.com/nodejs/node/pull/8739
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

9 years ago

Ojas Shirekar

2a2ec9dbc3

buffer: add isSharedArrayBuffer checks

Fixes: https://github.com/nodejs/node/issues/8440
PR-URL: https://github.com/nodejs/node/pull/8510
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

9 years ago

2 Commits (1e44fd960fe38b1191ed9ceb034eade3054b5531)