lukechilds/node - node - Gitea: Git with a cup of tea

16453 Commits

131 Branches

446 Tags

325 MiB

Tree: 1f911e1cd1

Commit Graph

Author	SHA1	Message	Date
Claudio Rodriguez	e9b6fbbf17	dgram: prefer strict equality, type validation - Enforces strict comparisons in dgram - bindState should always be strictly equal to one of the defined constant states, and newHandle type is a string. - Check that the argument `type` in createSocket is not null when it is of type 'object', before using its `type` property. - Adds a test to check dgram.createSocket is properly validating its `type` argument. PR-URL: https://github.com/nodejs/node/pull/8011 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com> Reviewed-By: Jackson Tian <shvyo1987@gmail.com>	9 years ago

Author

SHA1

Message

Date

Claudio Rodriguez

e9b6fbbf17

dgram: prefer strict equality, type validation

- Enforces strict comparisons in dgram - bindState should
always be strictly equal to one of the defined constant states,
and newHandle type is a string.

- Check that the argument `type` in createSocket is not null
when it is of type 'object', before using its `type` property.

- Adds a test to check dgram.createSocket is properly
validating its `type` argument.

PR-URL: https://github.com/nodejs/node/pull/8011
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Reviewed-By: Jackson Tian <shvyo1987@gmail.com>

9 years ago

1 Commits (1f911e1cd10fb1580fae7625485f2d87b30bba7f)