lukechilds/node - node - Gitea: Git with a cup of tea

8747 Commits

131 Branches

446 Tags

325 MiB

Tree: 217bb0c964

Commit Graph

Author	SHA1	Message	Date
isaacs	327b6e3e1d	stream: Don't emit 'end' unless read() called This solves the problem of calling `readable.pipe(writable)` after the readable stream has already emitted 'end', as often is the case when writing simple HTTP proxies. The spirit of streams2 is that things will work properly, even if you don't set them up right away on the first tick. This approach breaks down, however, because pipe()ing from an ended readable will just do nothing. No more data will ever arrive, and the writable will hang open forever never being ended. However, that does not solve the case of adding a `on('end')` listener after the stream has received the EOF chunk, if it was the first chunk received (and thus, length was 0, and 'end' got emitted). So, with this, we defer the 'end' event emission until the read() function is called. Also, in pipe(), if the source has emitted 'end' already, we call the cleanup/onend function on nextTick. Piping from an already-ended stream is thus the same as piping from a stream that is in the process of ending. Updates many tests that were relying on 'end' coming immediately, even though they never read() from the req. Fix #4942	12 years ago
isaacs	0cdf85e28d	Lint all the JavaScripts.	13 years ago
koichik	3df7c90c30	http: keep-alive should default with HTTP/1.1 server As RFC 2616 says we should, assume that servers will provide a persistent connection by default. > A significant difference between HTTP/1.1 and earlier versions of > HTTP is that persistent connections are the default behavior of any > HTTP connection. That is, unless otherwise indicated, the client > SHOULD assume that the server will maintain a persistent connection, > even after error responses from the server. > HTTP/1.1 applications that do not support persistent connections MUST > include the "close" connection option in every message. Fixes #2436.	13 years ago

Author

SHA1

Message

Date

isaacs

327b6e3e1d

stream: Don't emit 'end' unless read() called

This solves the problem of calling `readable.pipe(writable)` after the
readable stream has already emitted 'end', as often is the case when
writing simple HTTP proxies.

The spirit of streams2 is that things will work properly, even if you
don't set them up right away on the first tick.

This approach breaks down, however, because pipe()ing from an ended
readable will just do nothing.  No more data will ever arrive, and the
writable will hang open forever never being ended.

However, that does not solve the case of adding a `on('end')` listener
after the stream has received the EOF chunk, if it was the first chunk
received (and thus, length was 0, and 'end' got emitted).  So, with
this, we defer the 'end' event emission until the read() function is
called.

Also, in pipe(), if the source has emitted 'end' already, we call the
cleanup/onend function on nextTick.  Piping from an already-ended stream
is thus the same as piping from a stream that is in the process of
ending.

Updates many tests that were relying on 'end' coming immediately, even
though they never read() from the req.

Fix #4942

12 years ago

isaacs

0cdf85e28d

Lint all the JavaScripts.

13 years ago

koichik

3df7c90c30

http: keep-alive should default with HTTP/1.1 server

As RFC 2616 says we should, assume that servers will provide a persistent
connection by default.

> A significant difference between HTTP/1.1 and earlier versions of
> HTTP is that persistent connections are the default behavior of any
> HTTP connection. That is, unless otherwise indicated, the client
> SHOULD assume that the server will maintain a persistent connection,
> even after error responses from the server.

> HTTP/1.1 applications that do not support persistent connections MUST
> include the "close" connection option in every message.

Fixes #2436.

13 years ago

3 Commits (217bb0c9641f8b999f8a07d5fd9141e8c6cd1164)