lukechilds/node - node - Gitea: Git with a cup of tea

13131 Commits

131 Branches

446 Tags

325 MiB

Tree: 22f132e61d

Commit Graph

Author	SHA1	Message	Date
Tristian Flanagan	13834caa28	module: fix column offsets in errors Because Node modules are wrapped, errors on the first line of a file leak the wrapper to the user and report the wrong column number. This commit adds a line break to the module wrapper so that the first line is treated the same as all other lines. To compensate for the additional line, a line offset of -1 is also applied to errors. Fixes: https://github.com/nodejs/node/issues/2860 PR-URL: https://github.com/nodejs/node/pull/2867 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>	10 years ago

Author

SHA1

Message

Date

Tristian Flanagan

13834caa28

module: fix column offsets in errors

Because Node modules are wrapped, errors on the first line
of a file leak the wrapper to the user and report the wrong
column number. This commit adds a line break to the module
wrapper so that the first line is treated the same as all
other lines. To compensate for the additional line, a line
offset of -1 is also applied to errors.

Fixes: https://github.com/nodejs/node/issues/2860
PR-URL: https://github.com/nodejs/node/pull/2867
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

10 years ago

1 Commits (22f132e61d899b7cd5e47c7f1d2f2630776177c5)