lukechilds/node - node - Gitea: Git with a cup of tea

13758 Commits

131 Branches

446 Tags

325 MiB

Tree: 236b7e8dd1

Commit Graph

Author	SHA1	Message	Date
Rich Trott	676e61872f	test: apply correct assert.fail() arguments The assert.fail function signature has the message as the third argument but, understandably, it is often assumed that it is the first argument (or at least the first argument if no other arguments are passed). This corrects the assert.fail() invocations in the Node.js tests. Before: assert.fail('message'); // result: AssertionError: 'message' undefined undefined After: assert.fail(null, null, 'message'); // result: AssertionError: message PR-URL: https://github.com/nodejs/node/pull/3378 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>	10 years ago
Alexis Campailla	4144cb054c	test: add test-spawn-cmd-named-pipe Adding a Windows test to verify that a node process spawned via cmd with named pipes can access its stdio streams. Ref: https://github.com/nodejs/node-v0.x-archive/issues/7345 PR-URL: https://github.com/nodejs/node/pull/2770 Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com> Reviewed-By: thefourtheye - Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: evanlucas - Evan Lucas <evanlucas@me.com>	10 years ago

Author

SHA1

Message

Date

Rich Trott

676e61872f

test: apply correct assert.fail() arguments

The assert.fail function signature has the message as the third argument
but, understandably, it is often assumed that it is the first argument
(or at least the first argument if no other arguments are passed).

This corrects the assert.fail() invocations in the Node.js tests.

Before:
assert.fail('message');
// result: AssertionError: 'message' undefined undefined

After:
assert.fail(null, null, 'message');
// result: AssertionError: message

PR-URL: https://github.com/nodejs/node/pull/3378
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

10 years ago

Alexis Campailla

4144cb054c

test: add test-spawn-cmd-named-pipe

Adding a Windows test to verify that a node process spawned via
cmd with named pipes can access its stdio streams.

Ref: https://github.com/nodejs/node-v0.x-archive/issues/7345

PR-URL: https://github.com/nodejs/node/pull/2770
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: thefourtheye - Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: evanlucas - Evan Lucas <evanlucas@me.com>

10 years ago

2 Commits (236b7e8dd160be9215cc581b5da1e3ebff67c265)