lukechilds/node - node - Gitea: Git with a cup of tea

16005 Commits

131 Branches

446 Tags

325 MiB

Tree: 2641cd496d

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Sam Roberts	c6aeb4491b	test: fix linting for test-tls-add-ca-cert.js Fix lint error introduced in `ea72331af` PR-URL: https://github.com/nodejs/node/pull/10771 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>	8 years ago
Sam Roberts	97a8bd20c6	test: check tls server verification with addCACert SecureContext.addCACert() adds to the existing root store, preserving root cert entries. option.ca is applied without calling SecureContext.addRootCerts() so should add to the default, empty, root store. This test confirms that the built-in root CAs are not included when options.ca is used. Based on: `acd5837fd7` PR-URL: https://github.com/nodejs/node/pull/10389 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>	8 years ago

Sam Roberts

c6aeb4491b

test: fix linting for test-tls-add-ca-cert.js

Fix lint error introduced in ea72331af

PR-URL: https://github.com/nodejs/node/pull/10771
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

8 years ago

Sam Roberts

97a8bd20c6

test: check tls server verification with addCACert

SecureContext.addCACert() adds to the existing root store,
preserving root cert entries. option.ca is applied without
calling SecureContext.addRootCerts() so should add to
the default, empty, root store.

This test confirms that the built-in root CAs are not included
when options.ca is used.

Based on:

acd5837fd7

PR-URL: https://github.com/nodejs/node/pull/10389
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

8 years ago

2 Commits (2641cd496d110c1a2a5a8ba97e6ad1120e9c919f)