lukechilds/node - node - Gitea: Git with a cup of tea

9042 Commits

131 Branches

446 Tags

325 MiB

Tree: 2769d97e67

Commit Graph

Author	SHA1	Message	Date
Timothy J Fontaine	41f55dc59b	test: net-GH-5504 child env needs NODE_COMMON_PORT	12 years ago
Ben Noordhuis	f548433195	test: use common.PORT in simple/test-net-GH-5504	12 years ago
isaacs	e0519ace31	net: Destroy when not readable and not writable This is only relevant for CentOS 6.3 using kernel version 2.6.32. On other linuxes and darwin, the `read` call gets an ECONNRESET in that case. On sunos, the `write` call fails with EPIPE. However, old CentOS will occasionally send an EOF instead of a ECONNRESET or EPIPE when the client has been destroyed abruptly. Make sure we don't keep trying to write or read more in that case. Fixes #5504 However, there is still the question of what libuv should do when it gets an EOF. Apparently in this case, it will continue trying to read, which is almost certainly the wrong thing to do. That should be fixed in libuv, even though this works around the issue.	12 years ago

Author

SHA1

Message

Date

Timothy J Fontaine

41f55dc59b

test: net-GH-5504 child env needs NODE_COMMON_PORT

12 years ago

Ben Noordhuis

f548433195

test: use common.PORT in simple/test-net-GH-5504

12 years ago

isaacs

e0519ace31

net: Destroy when not readable and not writable

This is only relevant for CentOS 6.3 using kernel version 2.6.32.

On other linuxes and darwin, the `read` call gets an ECONNRESET in that
case.  On sunos, the `write` call fails with EPIPE.

However, old CentOS will occasionally send an EOF instead of a
ECONNRESET or EPIPE when the client has been destroyed abruptly.

Make sure we don't keep trying to write or read more in that case.

Fixes #5504

However, there is still the question of what libuv should do when it
gets an EOF.  Apparently in this case, it will continue trying to read,
which is almost certainly the wrong thing to do.

That should be fixed in libuv, even though this works around the issue.

12 years ago

3 Commits (2769d97e67cb510706318f1c4a66e98a93472654)