lukechilds/node - node - Gitea: Git with a cup of tea

15654 Commits

131 Branches

446 Tags

325 MiB

Tree: 29b2e88e69

Commit Graph

Author	SHA1	Message	Date
Rich Trott	f0367d0edc	test: confirm globals not used internally PR-URL: https://github.com/nodejs/node/pull/5882 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>	9 years ago
Kyle Simpson	9fa25c8ca0	timers: fixing API refs to use safe internal refs Added safe internal references for 'clearTimeout(..)', 'active(..)', and 'unenroll(..)'. Changed various API refs from 'export.*' to use these safe internal references. Now, overwriting the global API identifiers does not create potential breakage and/or race conditions. See Issue #2493. PR-URL: https://github.com/nodejs/node/pull/5882 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Fixes: https://github.com/nodejs/node/issues/2493	9 years ago

Author

SHA1

Message

Date

Rich Trott

f0367d0edc

test: confirm globals not used internally

PR-URL: https://github.com/nodejs/node/pull/5882
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

9 years ago

Kyle Simpson

9fa25c8ca0

timers: fixing API refs to use safe internal refs

Added safe internal references for 'clearTimeout(..)', 'active(..)', and
'unenroll(..)'. Changed various API refs from 'export.*' to use these
safe internal references.

Now, overwriting the global API identifiers does not create potential
breakage and/or race conditions. See Issue #2493.

PR-URL: https://github.com/nodejs/node/pull/5882
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Fixes: https://github.com/nodejs/node/issues/2493

9 years ago

2 Commits (29b2e88e690ae7f23412e4c0d6f58a3663c8e390)