lukechilds/node - node - Gitea: Git with a cup of tea

Author	SHA1	Message	Date
Sakthipriyan Vairamani	d5ab92bcc1	test: use common.isWindows consistently In the tests, we use "process.platform === 'win32'" in some places. This patch replaces them with the "common.isWindows" for consistency. PR-URL: https://github.com/nodejs/io.js/pull/2269 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>	9 years ago
Roman Reiss	f29762f4dd	test: enable linting for tests Enable linting for the test directory. A number of changes was made so all tests conform the current rules used by lib and src directories. The only exception for tests is that unreachable (dead) code is allowed. test-fs-non-number-arguments-throw had to be excluded from the changes because of a weird issue on Windows CI. PR-URL: https://github.com/nodejs/io.js/pull/1721 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>	10 years ago
Sam Roberts	65b1e4f56f	dgram: implicit binds should be exclusive Server sockets should be shared by default, and client sockets should be exclusive by default. For net/TCP, this is how it is, for dgram/UDP, its a little less clear what a client socket is, but a socket that is auto-bound during a dgram.send() is not usefully shared among cluster workers, any more than an outgoing TCP connection would be usefully shared. Since implicit binds become exclusive, implicit/client dgram sockets can now be used with cluster on Windows. Before, neither explicit nor implicitly bound sockets could be used, causing dgram to be completely unsupported with cluster on Windows. After this change, they become half supported. PR: https://github.com/iojs/io.js/pull/325 PR: https://github.com/joyent/node/pull/8643 Reviewed-by: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-by: Bert Belder <bertbelder@gmail.com>	10 years ago
Ben Noordhuis	0526d834f9	Revert "dgram: implicit binds should be exclusive" This reverts commit `a32b92dbcf`. Reverted for breaking the parallel/test-cluster-dgram-2 test on all platforms. PR-URL: https://github.com/iojs/io.js/pull/279 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>	10 years ago
Sam Roberts	a32b92dbcf	dgram: implicit binds should be exclusive Server sockets should be shared by default, and client sockets should be exclusive by default. For net/TCP, this is how it is, for dgram/UDP, its a little less clear what a client socket is, but a socket that is auto-bound during a dgram.send() is not usefully shared among cluster workers, any more than an outgoing TCP connection would be usefully shared. Since implicit binds become exclusive, implicit/client dgram sockets can now be used with cluster on Windows. Before, neither explicit nor implicitly bound sockets could be used, causing dgram to be completely unsupported with cluster on Windows. After this change, they become half supported. PR-URL: https://github.com/joyent/node/pull/8643 Reviewed-by: Bert Belder <bertbelder@gmail.com>	10 years ago