lukechilds/node - node - Gitea: Git with a cup of tea

Commit Graph

Author	SHA1	Message	Date
Ruben Bridgewater	e167ab71fb	benchmark: var to const PR-URL: https://github.com/nodejs/node/pull/13757 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>	7 years ago
Rich Trott	496f60489d	tools,benchmark: use stricter indentation linting Enable stricter indentation rules for benchmark code. PR-URL: https://github.com/nodejs/node/pull/13895 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>	8 years ago
Refael Ackermann	8d2bd5fa88	test,benchmark: stabilize child-process also some cleanup PR-URL: https://github.com/nodejs/node/pull/13457 Refs: https://github.com/nodejs/node/issues/12817 Reviewed-By: Tobias Nießen <tniessen@tnie.de>	8 years ago
Refael Ackermann	68c933c01e	test: fix flakyness with `yes.exe` PR-URL: https://github.com/nodejs/node/pull/12821 Fixes: https://github.com/nodejs/node/issues/12817 Refs: https://github.com/nodejs/node/pull/12658 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>	8 years ago
Rich Trott	a1a54ca3f1	benchmark: terminate child process on Windows test-benchmark-child-process failures reveal that child-process-exec-stdout benchmark sometimes leaves around a stray yes.exe process. Add code to terminate the process. PR-URL: https://github.com/nodejs/node/pull/12658 Ref: https://github.com/nodejs/node/issues/12560 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: James M Snell <jasnell@gmail.com>	8 years ago
Joyee Cheung	3d7c82bd61	test: add test for child_process benchmark PR-URL: https://github.com/nodejs/node/pull/12326 Ref: https://github.com/nodejs/node/issues/12068 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>	8 years ago
Vse Mozhet Byt	0f69f40af0	benchmark: replace more [].join() with ''.repeat() Refs: https://github.com/nodejs/node/pull/12170 PR-URL: https://github.com/nodejs/node/pull/12317 Reviewed-By: James M Snell <jasnell@gmail.com>	8 years ago
Brian White	61ebfa8d1f	tools: add unescaped regexp dot rule to linter PR-URL: https://github.com/nodejs/node/pull/11834 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>	8 years ago
Vse Mozhet Byt	dd81d539e2	child_process: fix deoptimizing use of arguments Removed or fixed use of arguments in execFile(), normalizeExecArgs(), and normalizeSpawnArguments(). Refs: https://github.com/nodejs/node/issues/10323 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=6010 PR-URL: https://github.com/nodejs/node/pull/11535 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>	8 years ago
Yuya Tanaka	1216a34590	benchmark: cleanup child_process IPC benchmark Squashed from: - child_process: fix IPC bench to obey send() ret val - child_process: fix IPC benchmark message has two more bytes - child_process: use setImmediate for IPC bench PR-URL: https://github.com/nodejs/node/pull/10557 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net>	8 years ago
Bartosz Sosnowski	d5bc52aa2e	benchmark: use 'yes' instead of echo in a loop This changes child-process-exec-stdout benchmark to use 'yes' instead of echo in a while loop. This makes this benchmark consistent with child-process-read which already uses `yes` and allows this benchmark to be executed on Windows. Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> PR-URL: https://github.com/nodejs/node/pull/8721	8 years ago
Rich Trott	5b63d48e9e	lib,benchmark,test: implement consistent braces This change is in preparation for lint-enforced brace style. PR-URL: https://github.com/nodejs/node/pull/7630 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>	9 years ago
Bartosz Sosnowski	5386b23f64	benchmark: fix child-process-exec-stdout on win This benchmark fails on Windows when trying to execute command which is more than 32k in size. This commits skips this one case when running under Windows. PR-URL: https://github.com/nodejs/node/pull/7178 Reviewed-By: Trott - Rich Trott <rtrott@gmail.com> Reviewed-By: orangemocha - Alexis Campailla <orangemocha@nodejs.org>	9 years ago
Bartosz Sosnowski	cbbdc298b0	benchmark: fix child-process-read on Windows Under Windows 'ipc' communication requires the other process to format its messages with 'IPC framing protocol'. Otherwise, an assert is triggered in libuv. This commit changes child-process-read benchmark to use stdout to communicate with parent process. It also adds child-process-read-ipc.js to benchmark IPC communication using child node process. PR-URL: https://github.com/nodejs/node/pull/6971 Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: James M Snell <jasnell@gmail.com>	9 years ago
Rich Trott	c9a5990a76	child_process: measure buffer length in bytes This change fixes a known issue where `maxBuffer` limits by characters rather than bytes. Benchmark added to confirm no performance regression occurs with this change. PR-URL: https://github.com/nodejs/node/pull/6764 Fixes: https://github.com/nodejs/node/issues/1901 Reviewed-By: Brian White <mscdex@mscdex.net>	9 years ago
Andreas Madsen	d9079ab801	benchmark: move misc to categorized directories PR-URL: https://github.com/nodejs/node/pull/5177 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>	9 years ago

16 Commits (2bf182dc46f9da7c9ed98d9f98898f815da0d2f6)