lukechilds/node - node - Gitea: Git with a cup of tea

9853 Commits

131 Branches

446 Tags

325 MiB

Tree: 2c6b424829

Commit Graph

Author	SHA1	Message	Date
Sam Roberts	cb1646f44e	test: fix assumption of worker exit on disconnect Master was disconnecting its workers as soon as they both started up. Meanwhile, the workers were trying to listen. Its a race, sometimes the disconnect would happen between when worker gets the response message, and acks that message with a 'listening'. This worked OK after v0.11 introduced a behaviour where disconnect would always exit the worker, but once that backwards-incompatible behaviour is removed, the worker lives long enough to try and respond to the master, and child_process errors at the attempt to send from a disconnected child.	11 years ago
Ben Noordhuis	81655a224a	test: don't call process.exit() in debugger tests process.exit() tends to hide bugs, both in tests and node.js. Rewrite the tests so that the event loop exits naturally.	12 years ago
Miroslav Bajtoš	43ec1b1c2e	debugger, cluster: each worker has new debug port Implement support for debugging cluster workers. Each worker process is assigned a new debug port in an increasing sequence. I.e. when master process uses port 5858, then worker 1 uses port 5859, worker 2 uses port 5860, and so on. Introduce new command-line parameter '--debug-port=' which sets debug_port but does not start debugger. This option works for all node processes, it is not specific to cluster workers. Fixes joyent/node#5318.	12 years ago

Author

SHA1

Message

Date

Sam Roberts

cb1646f44e

test: fix assumption of worker exit on disconnect

Master was disconnecting its workers as soon as they both started up.
Meanwhile, the workers were trying to listen. Its a race, sometimes the
disconnect would happen between when worker gets the response message,
and acks that message with a 'listening'. This worked OK after v0.11
introduced a behaviour where disconnect would always exit the worker,
but once that backwards-incompatible behaviour is removed, the worker
lives long enough to try and respond to the master, and child_process
errors at the attempt to send from a disconnected child.

11 years ago

Ben Noordhuis

81655a224a

test: don't call process.exit() in debugger tests

process.exit() tends to hide bugs, both in tests and node.js.
Rewrite the tests so that the event loop exits naturally.

12 years ago

Miroslav Bajtoš

43ec1b1c2e

debugger, cluster: each worker has new debug port

Implement support for debugging cluster workers. Each worker process
is assigned a new debug port in an increasing sequence.

I.e. when master process uses port 5858, then worker 1 uses port 5859,
worker 2 uses port 5860, and so on.

Introduce new command-line parameter '--debug-port=' which sets debug_port
but does not start debugger. This option works for all node processes, it
is not specific to cluster workers.

Fixes joyent/node#5318.

12 years ago

3 Commits (2c6b424829caf0a4c07839c4daac3a438c0f0c9a)