lukechilds/node - node - Gitea: Git with a cup of tea

18862 Commits

131 Branches

446 Tags

325 MiB

Tree: 3070d53e31

Commit Graph

Author	SHA1	Message	Date
Vse Mozhet Byt	44bb140734	test: replace CRLF by LF in a fixture test/fixtures/test-error-first-line-offset.js is used in the test/sequential/test-module-loading.js, but the line break type is insignificant. It can be replaced for consistency. PR-URL: https://github.com/nodejs/node/pull/14437 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>	8 years ago
Tristian Flanagan	dfee4e3712	module: fix column offsets in errors Because Node modules are wrapped, errors on the first line of a file leak the wrapper to the user and report the wrong column number. This commit adds a line break to the module wrapper so that the first line is treated the same as all other lines. To compensate for the additional line, a line offset of -1 is also applied to errors. Fixes: https://github.com/nodejs/node/issues/2860 PR-URL: https://github.com/nodejs/node/pull/2867 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>	10 years ago

Author

SHA1

Message

Date

Vse Mozhet Byt

44bb140734

test: replace CRLF by LF in a fixture

test/fixtures/test-error-first-line-offset.js is used in the
test/sequential/test-module-loading.js, but the line break type
is insignificant. It can be replaced for consistency.

PR-URL: https://github.com/nodejs/node/pull/14437
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>

8 years ago

Tristian Flanagan

dfee4e3712

module: fix column offsets in errors

Because Node modules are wrapped, errors on the first line
of a file leak the wrapper to the user and report the wrong
column number. This commit adds a line break to the module
wrapper so that the first line is treated the same as all
other lines. To compensate for the additional line, a line
offset of -1 is also applied to errors.

Fixes: https://github.com/nodejs/node/issues/2860
PR-URL: https://github.com/nodejs/node/pull/2867
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

10 years ago

2 Commits (3070d53e31a09be5f8b121dc13d844d04a5541ee)