lukechilds/node - node - Gitea: Git with a cup of tea

16835 Commits

131 Branches

446 Tags

325 MiB

Tree: 30f1e8ea04

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Rich Trott	78cdd4baa4	test: include all stdio strings for fork() test-child-process-fork-stdio-string-variant was only testing 'pipe' for its `stdio` value. Add `inherit` and `ignore`. Also added a `common.mustCall()` to verify that the `message` event is triggered. PR-URL: https://github.com/nodejs/node/pull/11783 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>	8 years ago
Sam Roberts	4cafa60c99	child_process: align fork/spawn stdio error msg fork()'s support for .stdio strings in `3268863eb` used a different TypeError string from spawn, unnecessarily. PR-URL: https://github.com/nodejs/node/pull/11044 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>	8 years ago
Javis Sullivan	3268863ebc	child_process: add string shortcut for fork stdio Add string shortcut option for stdio parameter. Fixes: https://github.com/nodejs/node/issues/10793 PR-URL: https://github.com/nodejs/node/pull/10866 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Brian White <mscdex@mscdex.net>	8 years ago

Rich Trott

78cdd4baa4

test: include all stdio strings for fork()

test-child-process-fork-stdio-string-variant was only testing 'pipe' for
its `stdio` value. Add `inherit` and `ignore`.

Also added a `common.mustCall()` to verify that the `message` event is
triggered.

PR-URL: https://github.com/nodejs/node/pull/11783
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

8 years ago

Sam Roberts

4cafa60c99

child_process: align fork/spawn stdio error msg

fork()'s support for .stdio strings in 3268863eb used a different
TypeError string from spawn, unnecessarily.

PR-URL: https://github.com/nodejs/node/pull/11044
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>

8 years ago

Javis Sullivan

3268863ebc

child_process: add string shortcut for fork stdio

Add string shortcut option for stdio parameter.

Fixes: https://github.com/nodejs/node/issues/10793
PR-URL: https://github.com/nodejs/node/pull/10866
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Brian White <mscdex@mscdex.net>

8 years ago

3 Commits (30f1e8ea041c97370534b9d26eef8f25da18a75c)