lukechilds/node - node - Gitea: Git with a cup of tea

16553 Commits

131 Branches

446 Tags

325 MiB

Tree: 35f911152a

Commit Graph

Author SHA1 Message Date

Author	SHA1	Message	Date
Alexey Orlenko	55cbe24c60	zlib: fix node crashing on invalid options This is a partial backport of semver-patch bits of `9e4660b518`. This commit fixes the Node process crashing when constructors of classes of the zlib module are given invalid options. * Throw an Error when the zlib library rejects the value of windowBits, instead of crashing with an assertion. * Treat windowBits and memLevel options consistently with other ones and don't crash when non-numeric values are given. PR-URL: https://github.com/nodejs/node/pull/13098 Backport-PR-URL: https://github.com/nodejs/node/pull/13201 Fixes: https://github.com/nodejs/node/issues/13082 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>	8 years ago

Alexey Orlenko

55cbe24c60

zlib: fix node crashing on invalid options

This is a partial backport of semver-patch bits of
9e4660b518.

This commit fixes the Node process crashing when constructors of classes
of the zlib module are given invalid options.

* Throw an Error when the zlib library rejects the value of windowBits,
  instead of crashing with an assertion.

* Treat windowBits and memLevel options consistently with other ones and
  don't crash when non-numeric values are given.

PR-URL: https://github.com/nodejs/node/pull/13098
Backport-PR-URL: https://github.com/nodejs/node/pull/13201
Fixes: https://github.com/nodejs/node/issues/13082
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

8 years ago

1 Commits (35f911152ae4ece71d8d1205dca16b5e994550b5)