lukechilds/node - node - Gitea: Git with a cup of tea

2287 Commits

131 Branches

446 Tags

325 MiB

Tree: 372a7c9a3e

Commit Graph

Author	SHA1	Message	Date
Benjamin Thomas	cda1a38426	Fix bug in process._tickCallback where callbacks can get abandoned. Change process._tickCallback so that if a callback throws an error but there are other callbacks after it, we indicate that process._tickCallback needs to be ran again. Currently, if a callback in process._tickCallback throws an error, and that error is caught by an uncaughtException handler and process.nextTick is never called again, then any other callbacks already added to the nextTickQueue won't be called again. Updated the next-tick-errors test to catch this scenario.	15 years ago
Benjamin Thomas	57642e2349	Fix process.nextTick so thrown errors don't confuse it. If the function for a process.nextTick throws an error, then the splice() never removes that function from the nextTickQueue array. This makes sure the functions that have been run in _tickCallback get removed regardless of errors. Also add a test for this.	15 years ago

Author

SHA1

Message

Date

Benjamin Thomas

cda1a38426

Fix bug in process._tickCallback where callbacks can get abandoned.

Change process._tickCallback so that if a callback throws an error but
there are other callbacks after it, we indicate that
process._tickCallback needs to be ran again.

Currently, if a callback in process._tickCallback throws an error, and
that error is caught by an uncaughtException handler and
process.nextTick is never called again, then any other callbacks already
added to the nextTickQueue won't be called again.

Updated the next-tick-errors test to catch this scenario.

15 years ago

Benjamin Thomas

57642e2349

Fix process.nextTick so thrown errors don't confuse it.

If the function for a process.nextTick throws an error, then the
splice() never removes that function from the nextTickQueue array.  This
makes sure the functions that have been run in _tickCallback get removed
regardless of errors.

Also add a test for this.

15 years ago

2 Commits (372a7c9a3ef377f203ecf453042101ee73328c88)