lukechilds/node - node - Gitea: Git with a cup of tea

Commit Graph

Author	SHA1	Message	Date
Rich Trott	1bee74de84	doc: require two-factor authentication Collaborators have elevated privileges. The CTC now requires Collaborator accounts to have two-factor authentication. This changes wording in the onboarding documentation to make it clear that two-factor authentication is required and not merely recommended. PR-URL: https://github.com/nodejs/node/pull/10529 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>	8 years ago
BethGriggs	8951d3e0e5	doc: remove repeated info onboarding.md COLLABORATOR_GUIDE.md and onboarding.md cover some of the same information. The aim of this commit is to remove duplicated information. PR-URL: https://github.com/nodejs/node/pull/9635 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>	8 years ago
Rich Trott	add885416f	doc: add ctc-review label information PR-URL: https://github.com/nodejs/node/pull/9072 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>	8 years ago
jessicaquynh	c2984ce19a	doc: explain why GitHub merge button is not used Adds documentation and explicit reasons on why the GitHub web interface button is not used. This was explained in the referenced issue by @TheAlphaNerd. Fixes: https://github.com/nodejs/node/issues/8893 PR-URL: https://github.com/nodejs/node/pull/9044 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>	8 years ago
Rich Trott	cad0423ce4	doc: encourage 2FA before onboarding In the onboarding document, add a note to ask the new Collaborator if they are using two-factor authentication on their GitHub account. If they are not, suggest that they enable it as their account will have elevated privileges in many of the Node.js repositories. PR-URL: https://github.com/nodejs/node/pull/8776 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Johan Bergstrom <bugs@bergstroem.nu> Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>	8 years ago
Rich Trott	676e624eb3	doc: add optional step to onboarding doc Include information on how to force push to the contributor's own branch so that pull requests show as merged in GitHub interface. PR-URL: https://github.com/nodejs/node/pull/8774 Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Johan Bergstrom <bugs@bergstroem.nu> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: James M Snell <jasnell@gmail.com>	8 years ago
Rich Trott	4c76881383	doc: update exercise portion of onboarding doc PR-URL: https://github.com/nodejs/node/pull/8559 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>	8 years ago
Rich Trott	54dc719663	doc: link onboarding to contributing guide Replace the description of the commit message requirements in onboarding.md with a link to the commit message requirements as they appear in the CONTRIBUTING.md. Advantages include: * Only one place to keep the commit message requirements up to date * Most collaborators being onboarded will already have several commits in their name and already be familiar with the requirements. So repeating information here makes finding the new information (about metadata, for example) harder to find. PR-URL: https://github.com/nodejs/node/pull/8529 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: James M Snell <jasnell@gmail.com>	8 years ago
Rich Trott	4a42ae3c6d	doc: update onboarding PR landing info Clarify a few items in the onboarding doc about landing a PR. One addition is to include the optional `Refs:` metadata. PR-URL: https://github.com/nodejs/node/pull/8479 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>	8 years ago
Rich Trott	75a2ad1f0b	doc: add CI help/support info to onboarding doc PR-URL: https://github.com/nodejs/node/pull/8407 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>	8 years ago
Rich Trott	e4ac083bad	doc: update CI content in onboarding doc * add node-test-pull-request link * minor formatting improvements PR-URL: https://github.com/nodejs/node/pull/8374 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>	8 years ago
Rich Trott	2501a38b79	doc: update landing pr info in onboarding doc Reword and re-organize. Only significant content change is to specifically call out the two-CTC-member-LGTM requirement for semver-major changes. PR-URL: https://github.com/nodejs/node/pull/8344 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>	8 years ago
Rich Trott	b180a5beca	doc: update Reviewing section of onboarding doc PR-URL; https://github.com/nodejs/node/pull/8086 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: jasnell - James M Snell <jasnell@gmail.com>	8 years ago
Rich Trott	ca6363b8ae	doc: minor updates to onboarding doc PR-URL: https://github.com/nodejs/node/pull/8060 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>	8 years ago
Rich Trott	fa1476cb50	doc: add POST_STATUS_TO_PR info to onboarding doc `POST_STATUS_TO_PR` previously did not work. Now it works. Update the onboarding documentation accordingly. PR-URL: https://github.com/nodejs/node/pull/8059 Reviewed-By: Anna Henningsen <anna@addaleax.net>	8 years ago
Bryan English	5d6d3ee5fb	doc: clarify "Reviewed-By" iff "LGTM" As per conversation with @Trott, make it clear that Reviewed-By lines should only be added for collaborators who've actually put a LGTM on the PR. PR-URL: https://github.com/nodejs/node/pull/7183 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: JacksonTian - Jackson Tian <shvyo1987@gmail.com>	9 years ago
Rich Trott	f3971ff117	doc: update labels and CI info in onboarding doc PR-URL: https://github.com/nodejs/node/pull/7006 Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>	9 years ago
Jeremiah Senkpiel	7a3ed98229	doc: add onboarding resources PR-URL: https://github.com/nodejs/node/pull/3726 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>	9 years ago

18 Commits (377ea285fb92c8f969c19d8d6ecce7f46a86fb54)