lukechilds/node - node - Gitea: Git with a cup of tea

16529 Commits

131 Branches

446 Tags

325 MiB

Tree: 389f29406a

Commit Graph

Author	SHA1	Message	Date
Rich Trott	a30ae72350	test: skip irrelevant test on Windows Skip test-cluster-disconnect-handles on Windows. PR-URL: https://github.com/nodejs/node/pull/12261 Ref: https://github.com/nodejs/node/pull/12197#issuecomment-292228866 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>	8 years ago
Rich Trott	83dab801e2	test: fix unreliable known_issues test `test-stdout-buffer-flush-on-exit` was not failing reliably on POSIX machines and not failing at all on Windows. Revised test fails reliably on POSIX and is skipped (in CI) on Windows where the issue does not exist. Fixes: https://github.com/nodejs/node/issues/6527 PR-URL: https://github.com/nodejs/node/pull/6555 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joao Reis <reis@janeasystems.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>	9 years ago

Author

SHA1

Message

Date

Rich Trott

a30ae72350

test: skip irrelevant test on Windows

Skip test-cluster-disconnect-handles on Windows.

PR-URL: https://github.com/nodejs/node/pull/12261
Ref: https://github.com/nodejs/node/pull/12197#issuecomment-292228866
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

8 years ago

Rich Trott

83dab801e2

test: fix unreliable known_issues test

`test-stdout-buffer-flush-on-exit` was not failing reliably on POSIX
machines and not failing at all on Windows. Revised test fails reliably
on POSIX and is skipped (in CI) on Windows where the issue does not
exist.

Fixes: https://github.com/nodejs/node/issues/6527
PR-URL: https://github.com/nodejs/node/pull/6555
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joao Reis <reis@janeasystems.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

9 years ago

2 Commits (389f29406ae780e2fd56bfccb8c13ae701337496)