lukechilds/node - node - Gitea: Git with a cup of tea

14010 Commits

131 Branches

446 Tags

325 MiB

Tree: 38c8fd4afb

Commit Graph

Author	SHA1	Message	Date
Santiago Gimeno	b95160daae	test: move the debugger tests back to parallel Run the debugger with `--port=common.PORT` to avoid the use of the same port. PR-URL: https://github.com/nodejs/node/pull/6246 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>	9 years ago
Rich Trott	00b2219420	test: move debugger tests to sequential The debugger tests in parallel fail with `make test` sometimes (all the time?). This appears to be related to running in parallel, as it does not fail with `make test-ci`, when run via `tools/test.py` or directly from the command line with `./node test/parallel/test-debugger-util-regression.js`. A separate issue may be opened to find out why it is failing in parallel, but for now, I think it's important to fix `make test` promptly. I suspect the issue is that the tests are relying on a default port somewhere and so they are colliding when run in parallel. But that's just a guess for the moment. PR-URL: https://github.com/nodejs/node/pull/6205 Fixes: https://github.com/nodejs/node/issues/6201 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>	9 years ago
Rich Trott	1df84f4f75	debugger: run last command on presssing enter PR-URL: https://github.com/nodejs/node/pull/6090 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Fixes: https://github.com/nodejs/node/issues/2895	9 years ago

Author

SHA1

Message

Date

Santiago Gimeno

b95160daae

test: move the debugger tests back to parallel

Run the debugger with `--port=common.PORT` to avoid the use of the same
port.

PR-URL: https://github.com/nodejs/node/pull/6246
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

9 years ago

Rich Trott

00b2219420

test: move debugger tests to sequential

The debugger tests in parallel fail with `make test` sometimes (all the
time?). This appears to be related to running in parallel, as it does
not fail with `make test-ci`, when run via `tools/test.py` or directly
from the command line with `./node
test/parallel/test-debugger-util-regression.js`.

A separate issue may be opened to find out why it is failing in
parallel, but for now, I think it's important to fix `make test`
promptly.

I suspect the issue is that the tests are relying on a default port
somewhere and so they are colliding when run in parallel. But that's
just a guess for the moment.

PR-URL: https://github.com/nodejs/node/pull/6205
Fixes: https://github.com/nodejs/node/issues/6201
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>

9 years ago

Rich Trott

1df84f4f75

debugger: run last command on presssing enter

PR-URL: https://github.com/nodejs/node/pull/6090
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Fixes: https://github.com/nodejs/node/issues/2895

9 years ago

3 Commits (38c8fd4afbfbe174b285d21af78782d47ee4964e)