lukechilds/node - node - Gitea: Git with a cup of tea

Tree: 38df9d51a2

Author	SHA1	Message	Date
Nathan Rajlich	3c91a7ae10	readline: use a "string_decoder" to parse "keypress" events While updating the readline test cases to test both "terimal: false" and "terminal: true" mode, it turned out that the test case testing utf8 chars being sent over multiple write() calls was failing. The solution is to use a string_decoder instance when parsing the "keypress" events.	13 years ago
Nathan Rajlich	e95e095289	readline: don't emit "line" events with a trailing '\n' char Before this commit, readline was inconsistent in whether or not it would emit "line" events with or without the trailing "\n" included. When "terminal" mode was true, then there would be no "\n", when it was false, then the "\n" would be present. However, the trailing "\n" doesn't add much, and most of the time people just end up stripping it manually. Part of #4243.	13 years ago
isaacs	e4c9c9f412	readline: Remove event listeners on close Fix #3756	13 years ago
Nathan Rajlich	78eb174ea2	readline: use StringDecoder for decoding "normal" data The fix from #3059 was not handling multi-byte utf8 data properly.	13 years ago
Nathan Friedly	e28f77cbad	readline: buffer data to only emit 'line' on '\n' In "terminal: false" mode. (And fire it multiple times if multiple lines arrive at once.) This is necessary because the Windows telnet client sends every single keystroke as it's typed. See: http://stackoverflow.com/questions/9962197/node-js-readline-not-waiting-for-a-full-line-on-socket-connections Closes #3059.	13 years ago