lukechilds/node - node - Gitea: Git with a cup of tea

11517 Commits

131 Branches

446 Tags

325 MiB

Tree: 39dde3222e

Commit Graph

Author	SHA1	Message	Date
Michaël Zasso	5773438913	test: fix jslint error PR-URL: https://github.com/nodejs/io.js/pull/1743 Fixes: https://github.com/nodejs/io.js/issues/1742 Reviewed-By: Roman Reiss <me@silverwind.io>	10 years ago
Santiago Gimeno	867631986f	test: fix test-sync-io-option Wait for all the data to be available in stderr before checking its contents. In FreeBSD this was failing because stderr data was being emitted in multiple chunks. 4 WARNINGS are printed instead of 2 for each sync call inside readFileSync. require('fs') does not print any trace. PR-URL: https://github.com/nodejs/io.js/pull/1734 Reviewed-By: Trevor Norris <trev.norris@gmail.com>	10 years ago
Trevor Norris	c1de6d249e	core: implement runtime flag to trace sync io Use the --trace-sync-io flag to print a stack trace whenever a sync method is used after the first tick, excluding during the process exit event. (e.g. fs.readFileSync()) It does not track if the warning has occurred at a specific location in the past and so will print the warning every time. Reason for not printing during the first tick of the appication is so all necessary resources can be required. Also by excluding synchronous calls during exit is necessary in case any data needs to be logged out by the application before it shuts down. Fixes: https://github.com/nodejs/io.js/issues/1674 PR-URL: https://github.com/nodejs/io.js/pull/1707 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Fedor Indutny <fedor@indutny.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Petka Antonov <petka_antonov@hotmail.com>	10 years ago

Author

SHA1

Message

Date

Michaël Zasso

5773438913

test: fix jslint error

PR-URL: https://github.com/nodejs/io.js/pull/1743
Fixes: https://github.com/nodejs/io.js/issues/1742
Reviewed-By: Roman Reiss <me@silverwind.io>

10 years ago

Santiago Gimeno

867631986f

test: fix test-sync-io-option

Wait for all the data to be available in stderr before checking its
contents. In FreeBSD this was failing because stderr data was being
emitted in multiple chunks. 4 WARNINGS are printed instead of 2 for
each sync call inside readFileSync. require('fs') does not print any
trace.

PR-URL: https://github.com/nodejs/io.js/pull/1734
Reviewed-By: Trevor Norris <trev.norris@gmail.com>

10 years ago

Trevor Norris

c1de6d249e

core: implement runtime flag to trace sync io

Use the --trace-sync-io flag to print a stack trace whenever a sync
method is used after the first tick, excluding during the process exit
event. (e.g. fs.readFileSync()) It does not track if the warning has
occurred at a specific location in the past and so will print the
warning every time.

Reason for not printing during the first tick of the appication is so
all necessary resources can be required. Also by excluding synchronous
calls during exit is necessary in case any data needs to be logged out
by the application before it shuts down.

Fixes: https://github.com/nodejs/io.js/issues/1674
PR-URL: https://github.com/nodejs/io.js/pull/1707
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Petka Antonov <petka_antonov@hotmail.com>

10 years ago

3 Commits (39dde3222e4733fc1b59c45e392d9ff1a88ae4cc)