lukechilds/node - node - Gitea: Git with a cup of tea

Author	SHA1	Message	Date
Trevor Norris	f0b68892d4	domain: fix domain callback from MakeCallback Since _tickCallback and _tickDomainCallback were both called from MakeCallback, it was possible for a callback to be called that required a domain directly to _tickCallback. The fix was to implement process.usingDomains(). This will set all applicable functions to their domain counterparts, and set a flag in cc to let MakeCallback know domain callbacks always need to be checked. Added test in own file. It's important that the test remains isolated.	12 years ago
Trevor Norris	0c1e7b53d0	process: separate nextTick domain logic It's cleaner to only load domain ticker logic when the domains are being used. This makes execution slightly quicker in both cases, and simpler from the spinner since there is no need to check if the latest callback requires use of domains.	12 years ago
isaacs	ec8ebaf300	domain: use camelCase instead of snake_case While it's true that error objects have a history of getting snake_case properties attached by the host system, it's a point of confusion to Node users that comes up a lot. It's still 'experimental', so best to change this sooner rather than later.	12 years ago
isaacs	4401bb47bf	domain: Do not use uncaughtException handler This adds a process._fatalException method which is called into from C++ in order to either emit the 'uncaughtException' method, or emit 'error' on the active domain. The 'uncaughtException' event is an implementation detail that it would be nice to deprecate one day, so exposing it as part of the domain machinery is not ideal. Fix #4375	12 years ago
Ryunosuke SATO	697484df82	domain: speed up domain.create Use `EventEmitter.call` instead of `EventEmitter.apply` because of performance.	12 years ago
isaacs	2a9a5e2318	domain: Remove stray console.log	12 years ago
isaacs	0400571676	domain: Properly exit() on domain disposal This addresses #4034. There are two problems happening: 1. The domain is not exited automatically when calling dispose() on it. Then, since the domain is disposed, attempting to exit it again will do nothing. 2. The active domain is stored on process.domain. Since thrown errors call `process.emit('uncaughtException', er)`, and the process is an event emitter with a `.domain` member, it re-enters the domain a second time before calling the error handler, pushing it onto the stack again. Thus, if the handler calls `domain.dispose()`, then the domain is now on the stack twice, and cannot be exited properly. Since the domain is disposed, any subsequent IO will be no-op'ed, since we've declared that this context is done and best forgotten. The solution here is twofold: 1. In EventEmitter.emit, do not enter the domain if `this===process`. 2. Automatically exit the domain when calling `domain.dispose()`.	12 years ago
isaacs	d6b78d0e37	domain: Fix stack leak on error	13 years ago
Toshihiro Nakamura	6530310ed5	domain: Remove first arg from intercepted fn Fix to remove the first-arg, in case arguments length is more than 2 Add domain.intercept() test about first-arg removal	13 years ago
Andreas Madsen	535e109a3a	domain: run now return callback result both domain.bind and domain.intercept act this way	13 years ago
Andreas Madsen	77cfbd9f2d	domain: dry decorate using util._extend	13 years ago
Marc Harter	569acea0ee	Fix #3379 prevent domain.intercept passing 1st arg to cb	13 years ago
isaacs	d8b33dc147	lint	13 years ago
isaacs	963459d736	Domain feature This is a squashed commit of the main work done on the domains-wip branch. The original commit messages are preserved for posterity: * Implicitly add EventEmitters to active domain * Implicitly add timers to active domain * domain: add members, remove ctor cb * Don't hijack bound callbacks for Domain error events * Add dispose method * Add domain.remove(ee) method * A test of multiple domains in process at once * Put the active domain on the process object * Only intercept error arg if explicitly requested * Typo * Don't auto-add new domains to the current domain While an automatic parent/child relationship is sort of neat, and leads to some nice error-bubbling characteristics, it also results in keeping a reference to every EE and timer created, unless domains are explicitly disposed of. * Explicitly adding one domain to another is still fine, of course. * Don't allow circular domain->domain memberships * Disposing of a domain removes it from its parent * Domain disposal turns functions into no-ops * More documentation of domains * More thorough dispose() semantics * An example using domains in an HTTP server * Don't handle errors on a disposed domain * Need to push, even if the same domain is entered multiple times * Array.push is too slow for the EE Ctor * lint domain * domain: docs * Also call abort and destroySoon to clean up event emitters * domain: Wrap destroy methods in a try/catch * Attach tick callbacks to active domain * domain: Only implicitly bind timers, not explicitly * domain: Don't fire timers when disposed. * domain: Simplify naming so that MakeCallback works on Timers * Add setInterval and nextTick to domain test * domain: Make stack private	13 years ago